[PATCH] Fix Apple Wireless keyboard pairing?

[PATCH] Fix Apple Wireless keyboard pairing?

[Bastien Nocera]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

Heya,

If anyone has an Apple Wireless keyboard to test pairing against. I
believe the attached patch to be correct. Otherwise Apple keyboards
(which use the same OUI) will get a PIN of 0000.

Cheers

[-- Attachment #2: bluez-apple-wireless-kbd.patch --]
[-- Type: text/x-patch, Size: 715 bytes --]

diff --git a/wizard/main.c b/wizard/main.c
index 0854913..0340063 100644
--- a/wizard/main.c
+++ b/wizard/main.c
@@ -62,9 +62,10 @@ static gboolean pincode_callback(DBusGMethodInvocation *context,
 	const char *pincode = target_pincode;
 	gchar *text;
 
-	/* Apple Wireless and Mighty Mouse */
-	if (g_str_has_prefix(target_address, "00:0A:95:") == TRUE ||
-			g_str_has_prefix(target_address, "00:14:51:") == TRUE)
+	/* Apple Wireless and Mighty Mouse, and just the mice */
+	if ((g_str_has_prefix(target_address, "00:0A:95:") == TRUE ||
+			g_str_has_prefix(target_address, "00:14:51:") == TRUE) &&
+	    target_type == BLUETOOTH_TYPE_MOUSE)
 		pincode = "0000";
 
 	/* Most headsets are using 0000 as pincode */

Re: [PATCH] Fix Apple Wireless keyboard pairing?

[Marcel Holtmann]

Hi Bastien,

> If anyone has an Apple Wireless keyboard to test pairing against. I
> believe the attached patch to be correct. Otherwise Apple keyboards
> (which use the same OUI) will get a PIN of 0000.

sounds reasonable. Patch has been applied. Thanks.

Regards

Marcel

Re: [PATCH] Fix Apple Wireless keyboard pairing?

[Mario Limonciello]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi Bastien:

I've got one of these Aluminum BT keyboards, but it's MAC address is
quite different:

00:1B:63:FA:CD:5A Apple Wireless Keyboard

Where did you get your data from indicating that it shared the same
prefix as the mighty mouse?

Regards

Bastien Nocera wrote:
> Heya,
>
> If anyone has an Apple Wireless keyboard to test pairing against. I
> believe the attached patch to be correct. Otherwise Apple keyboards
> (which use the same OUI) will get a PIN of 0000.
>
> Cheers
>   

-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: [PATCH] Fix Apple Wireless keyboard pairing?

[Bastien Nocera]

On Wed, 2008-10-15 at 13:40 -0500, Mario Limonciello wrote:
> Hi Bastien:
> 
> I've got one of these Aluminum BT keyboards, but it's MAC address is
> quite different:
> 
> 00:1B:63:FA:CD:5A Apple Wireless Keyboard
> 
> Where did you get your data from indicating that it shared the same
> prefix as the mighty mouse?

Some of them would. See bug report at:
https://bugzilla.redhat.com/show_bug.cgi?id=466988

Pairing keyboards still doesn't work as expected, but I should get some
hardware soon to fix that.

Cheers

Re: [PATCH] Fix Apple Wireless keyboard pairing?

[Mario Limonciello]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

Hi Bastien:

Yeah, I'll definitely agree these keyboards are quite finicky to get
paired.  I was initially hoping your patch would help that, but then
realized it won't affect mine.  It seems that the only way I've gotten
them to improve is if I remove any other devices that were paired with
them previously from the proximity and try to find a good combination of
pressing buttons in the GUI and pressing the power button on the keyboard.

I  think the poster to that bug has the older pre-broadcom series of
this hardware, which would explain the similar ID to the mighty mouse.

Regards

Bastien Nocera wrote:
> On Wed, 2008-10-15 at 13:40 -0500, Mario Limonciello wrote:
>   
>> Hi Bastien:
>>
>> I've got one of these Aluminum BT keyboards, but it's MAC address is
>> quite different:
>>
>> 00:1B:63:FA:CD:5A Apple Wireless Keyboard
>>
>> Where did you get your data from indicating that it shared the same
>> prefix as the mighty mouse?
>>     
>
> Some of them would. See bug report at:
> https://bugzilla.redhat.com/show_bug.cgi?id=466988
>
> Pairing keyboards still doesn't work as expected, but I should get some
> hardware soon to fix that.
>
> Cheers
>
>   

-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: [PATCH] Fix Apple Wireless keyboard pairing?

[Marcel Holtmann]

Hi Mario,

> Yeah, I'll definitely agree these keyboards are quite finicky to get
> paired.  I was initially hoping your patch would help that, but then
> realized it won't affect mine.  It seems that the only way I've gotten
> them to improve is if I remove any other devices that were paired with
> them previously from the proximity and try to find a good combination of
> pressing buttons in the GUI and pressing the power button on the keyboard.
> 
> I  think the poster to that bug has the older pre-broadcom series of
> this hardware, which would explain the similar ID to the mighty mouse.

please do me favor and stop top-posting.

http://www.bluez.org/development/lists/

Regards

Marcel