patch: Respect HCI_UART_DEBUG config in hci_ll.c

patch: Respect HCI_UART_DEBUG config in hci_ll.c

[Nick Pelly]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Author: Nick Pelly <npelly@google.com>
Date:   Mon Apr 21 12:18:51 2008 -0700

    bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c

    Following the pattern from hci_*.c, turn off BT_DBG messages unless
    they have been requested via HCI_UART_DEBUG

    Signed-off-by: Brian Swetland <swetland@google.com>

diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index b91d45a..2d2f66e 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -51,6 +51,11 @@

 #include "hci_uart.h"

+#ifndef CONFIG_BT_HCIUART_DEBUG
+#undef  BT_DBG
+#define BT_DBG( A... )
+#endif
+
 /* HCILL commands */
 #define HCILL_GO_TO_SLEEP_IND  0x30
 #define HCILL_GO_TO_SLEEP_ACK  0x31

[-- Attachment #2: fix_hcill_debug.txt --]
[-- Type: text/plain, Size: 759 bytes --]

commit 4c70181b749225534eaaca6b57ac48be6391c2b9
Author: Nick Pelly <npelly@google.com>
Date:   Mon Apr 21 12:18:51 2008 -0700

    bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c
    
    Following the pattern from hci_*.c, turn off BT_DBG messages unless
    they have been requested via HCI_UART_DEBUG
    
    Signed-off-by: Brian Swetland <swetland@google.com>

diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index b91d45a..2d2f66e 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -51,6 +51,11 @@
 
 #include "hci_uart.h"
 
+#ifndef CONFIG_BT_HCIUART_DEBUG
+#undef  BT_DBG
+#define BT_DBG( A... )
+#endif
+
 /* HCILL commands */
 #define HCILL_GO_TO_SLEEP_IND	0x30
 #define HCILL_GO_TO_SLEEP_ACK	0x31

Re: patch: Respect HCI_UART_DEBUG config in hci_ll.c

[Marcel Holtmann]

Hi Nick,

> Author: Nick Pelly <npelly@google.com>
> Date:   Mon Apr 21 12:18:51 2008 -0700
> 
>     bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c
> 
>     Following the pattern from hci_*.c, turn off BT_DBG messages unless
>     they have been requested via HCI_UART_DEBUG
> 
>     Signed-off-by: Brian Swetland <swetland@google.com>

you have to fix your mail client to _NOT_ send mutli-part crap. Please
follow the proper guidelines for sending kernel patches. Otherwise you
make it complicated for me to apply patches. Especially these no
brainers.

So who wrote this patch? You are Brian. If you wrote the patch like
author indicated, then Brian should do an Acked-by unless he actually
sends the patch to me. In this case you send the patch so it should look
like this:

Signed-off-by: Nick Pelly <npelly@google.com>
Acked-by: Brian Swetland <swetland@google.com>

If you wrote the patch and Brian sent it to me, then he has to do
Signed-off since he is part of the chain. It is all documented in the
kernel source code :)

Regards

Marcel

Re: patch: Respect HCI_UART_DEBUG config in hci_ll.c

[Nick Pelly]

Author: Nick Pelly <npelly@google.com>
Date:   Mon Apr 21 12:18:51 2008 -0700

  bluetooth: Respect HCI_UART_DEBUG config in hci_ll.c

  Following the pattern from hci_*.c, turn off BT_DBG messages unless
  they have been requested via HCI_UART_DEBUG

  Signed-off-by: Nick Pelly <npelly@google.com>
  Acked-by: Brian Swetland <swetland@google.com>

diff --git a/drivers/bluetooth/hci_ll.c b/drivers/bluetooth/hci_ll.c
index b91d45a..2d2f66e 100644
--- a/drivers/bluetooth/hci_ll.c
+++ b/drivers/bluetooth/hci_ll.c
@@ -51,6 +51,11 @@

 #include "hci_uart.h"

+#ifndef CONFIG_BT_HCIUART_DEBUG
+#undef  BT_DBG
+#define BT_DBG( A... )
+#endif
+
 /* HCILL commands */
 #define HCILL_GO_TO_SLEEP_IND  0x30
 #define HCILL_GO_TO_SLEEP_ACK  0x31