From: Marcel Holtmann <marcel@holtmann.org>
To: Siarhei Siamashka <siarhei.siamashka@nokia.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] SBC encoder scale factors calculation optimized with __builtin_clz
Date: Thu, 29 Jan 2009 08:27:38 +0100 [thread overview]
Message-ID: <1233214058.2139.6.camel@violet> (raw)
In-Reply-To: <200901290310.03440.siarhei.siamashka@nokia.com>
Hi Siarhei,
> The attached patch contains optimization for scale factors calculation which
> provides additional SBC encoder speedup.
>
> For non-gcc compilers, CLZ function is implemented with a very simple and
> slow straightforward code (but it is still faster than current git code even
> if used instead of __builtin_clz). Something better could be done like:
> http://groups.google.com/group/comp.sys.arm/msg/5ae56e3a95a2345e?hl=en
> But I'm not sure about license/copyright of the code at this link and decided
> not to touch it. Anyway, I don't think that gcc implementation of
> __builtin_clz for the CPU cores which do not support CLZ instruction is any
> worse.
personally I don't really care about non-gcc compilers. I think that
some of the BlueZ source might not even compile without gcc.
Anyway, patch has been applied. Thanks.
Regards
Marcel
next prev parent reply other threads:[~2009-01-29 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 1:10 [PATCH] SBC encoder scale factors calculation optimized with __builtin_clz Siarhei Siamashka
2009-01-29 1:20 ` Siarhei Siamashka
2009-01-29 7:28 ` Marcel Holtmann
2009-01-29 9:07 ` Christian Hoene
2009-01-29 9:51 ` Johan Hedberg
2009-01-29 7:27 ` Marcel Holtmann [this message]
2009-01-29 15:00 ` Christian Hoene
2009-01-29 15:30 ` Siarhei Siamashka
2009-01-29 16:31 ` Siarhei Siamashka
2009-01-29 17:01 ` Marcel Holtmann
2009-01-30 11:14 ` Christian Hoene
2009-01-30 17:05 ` Siarhei Siamashka
2009-02-01 16:53 ` Marcel Holtmann
2009-02-02 10:48 ` Siarhei Siamashka
2009-02-02 15:20 ` Marcel Holtmann
2009-03-16 19:32 ` Siarhei Siamashka
2009-02-02 11:11 ` Siarhei Siamashka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233214058.2139.6.camel@violet \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=siarhei.siamashka@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox