From: Marcel Holtmann <marcel@holtmann.org>
To: Siarhei Siamashka <siarhei.siamashka@nokia.com>
Cc: ext Christian Hoene <hoene@uni-tuebingen.de>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] SBC encoder scale factors calculation optimized with __builtin_clz
Date: Thu, 29 Jan 2009 18:01:35 +0100 [thread overview]
Message-ID: <1233248495.2139.19.camel@violet> (raw)
In-Reply-To: <200901291831.49427.siarhei.siamashka@nokia.com>
Hi Siarhei,
> > > The testing results are not positive. It is better to revoke the patch.
> > > http://net.cs.uni-tuebingen.de/html/nexgenvoip/
> > > http://net.cs.uni-tuebingen.de/html/nexgenvoip/html/encoder.bluez.03.wav
> >
> > Thanks for finding the bug. A common things about these failed testcases
> > is that block size is not 16.
> >
> > Looks like this was not covered by my own regression tests, I'll try to do
> > something about this problem now.
>
> A fix is attached. I also extended my regression test script to cover such
> cases.
patch has been applied. Thanks.
Regards
Marcel
next prev parent reply other threads:[~2009-01-29 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 1:10 [PATCH] SBC encoder scale factors calculation optimized with __builtin_clz Siarhei Siamashka
2009-01-29 1:20 ` Siarhei Siamashka
2009-01-29 7:28 ` Marcel Holtmann
2009-01-29 9:07 ` Christian Hoene
2009-01-29 9:51 ` Johan Hedberg
2009-01-29 7:27 ` Marcel Holtmann
2009-01-29 15:00 ` Christian Hoene
2009-01-29 15:30 ` Siarhei Siamashka
2009-01-29 16:31 ` Siarhei Siamashka
2009-01-29 17:01 ` Marcel Holtmann [this message]
2009-01-30 11:14 ` Christian Hoene
2009-01-30 17:05 ` Siarhei Siamashka
2009-02-01 16:53 ` Marcel Holtmann
2009-02-02 10:48 ` Siarhei Siamashka
2009-02-02 15:20 ` Marcel Holtmann
2009-03-16 19:32 ` Siarhei Siamashka
2009-02-02 11:11 ` Siarhei Siamashka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233248495.2139.19.camel@violet \
--to=marcel@holtmann.org \
--cc=hoene@uni-tuebingen.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=siarhei.siamashka@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox