From: Marcel Holtmann <marcel@holtmann.org>
To: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools: Fix memory leaks
Date: Mon, 09 Feb 2009 13:31:21 +0100 [thread overview]
Message-ID: <1234182681.4705.7.camel@californication> (raw)
In-Reply-To: <1234149329-4536-1-git-send-email-gustavo@las.ic.unicamp.br>
Hi Gustavo,
> Some printfs was using as parameter functions that return dinamic
> allocated memory. Now, we free them!
>
> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
BlueZ doesn't use Signed-off-by for commit messages. That is kernel
stuff.
> @@ -1586,10 +1592,13 @@ static void print_dev_hdr(struct hci_dev_info *di)
> static void print_dev_info(int ctl, struct hci_dev_info *di)
> {
> struct hci_dev_stats *st = &di->stat;
> + char * str;
This needs to be "char *str;"
Please fix it and re-sent the patch.
Regards
Marcel
next prev parent reply other threads:[~2009-02-09 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 3:15 [PATCH] tools: Fix memory leaks Gustavo F. Padovan
2009-02-09 12:31 ` Marcel Holtmann [this message]
2009-02-09 13:28 ` Gustavo F. Padovan
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 23:50 Gustavo F. Padovan
2009-02-10 15:43 ` Marcel Holtmann
2009-02-10 17:23 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234182681.4705.7.camel@californication \
--to=marcel@holtmann.org \
--cc=gustavo@las.ic.unicamp.br \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox