From: "Gustavo F. Padovan" <gustavo@las.ic.unicamp.br>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools: Fix memory leaks
Date: Mon, 9 Feb 2009 11:28:25 -0200 [thread overview]
Message-ID: <6b53b1990902090528j3ed41c65p7bb03ab43a8dc224@mail.gmail.com> (raw)
In-Reply-To: <1234182681.4705.7.camel@californication>
On Mon, Feb 9, 2009 at 10:31 AM, Marcel Holtmann <marcel@holtmann.org> wrot=
e:
> Hi Gustavo,
>
>> Some printfs was using as parameter functions that return dinamic
>> allocated memory. Now, we free them!
>>
>> Signed-off-by: Gustavo F. Padovan <gustavo@las.ic.unicamp.br>
>
> BlueZ doesn't use Signed-off-by for commit messages. That is kernel
> stuff.
>
>> @@ -1586,10 +1592,13 @@ static void print_dev_hdr(struct hci_dev_info *d=
i)
>> static void print_dev_info(int ctl, struct hci_dev_info *di)
>> {
>> struct hci_dev_stats *st =3D &di->stat;
>> + char * str;
>
> This needs to be "char *str;"
>
> Please fix it and re-sent the patch.
Ok.
>
> Regards
>
> Marcel
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth=
" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--=20
----------------------------------------------
Gustavo Fernando Padovan
Engenharia de Computa=E7=E3o 2006
Instituto de Computa=E7=E3o - UNICAMP
gfpadovan@gmail.com
gustavo@las.ic.unicamp.br
-------------------------------------------
Seja Livre, use Software Livre
next prev parent reply other threads:[~2009-02-09 13:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 3:15 [PATCH] tools: Fix memory leaks Gustavo F. Padovan
2009-02-09 12:31 ` Marcel Holtmann
2009-02-09 13:28 ` Gustavo F. Padovan [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-09 23:50 Gustavo F. Padovan
2009-02-10 15:43 ` Marcel Holtmann
2009-02-10 17:23 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b53b1990902090528j3ed41c65p7bb03ab43a8dc224@mail.gmail.com \
--to=gustavo@las.ic.unicamp.br \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox