public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Bea Lam <bea.lam@trolltech.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Add "Class" property to org.bluez.Adapter
Date: Wed, 04 Mar 2009 22:04:02 +0100	[thread overview]
Message-ID: <1236200642.6670.13.camel@localhost.localdomain> (raw)
In-Reply-To: <49ADD4C8.8040705@trolltech.com>

Hi Bea,

> I mentioned on IRC a while back that a "Class" property for the Adapter
> interface might be useful. I've attached a patch to this effect. Please
> let me know if there are any issues.

+       /* Class */
+       class = adapter->dev.class[0]
+               | (adapter->dev.class[1] << 8)
+               | (adapter->dev.class[2] << 16);
+       dict_append_entry(&dict, "Class", DBUS_TYPE_UINT32, &class);
+

This should more like this:

	class = adapter->dev.class[0] |
			adapter->dev.class[1] << 8 | ...

Regards

Marcel



  reply	other threads:[~2009-03-04 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-04  1:09 [PATCH] Add "Class" property to org.bluez.Adapter Bea Lam
2009-03-04 21:04 ` Marcel Holtmann [this message]
2009-03-05  0:24   ` Bea Lam
2009-03-12 15:09     ` Johan Hedberg
2009-03-16  1:38       ` Bea Lam
2009-03-16  2:20         ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236200642.6670.13.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=bea.lam@trolltech.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox