From: Bea Lam <bea.lam@trolltech.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH] Add "Class" property to org.bluez.Adapter
Date: Wed, 04 Mar 2009 11:09:28 +1000 [thread overview]
Message-ID: <49ADD4C8.8040705@trolltech.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
Hi Marcel,
I mentioned on IRC a while back that a "Class" property for the Adapter
interface might be useful. I've attached a patch to this effect. Please
let me know if there are any issues.
cheers,
Bea
[-- Attachment #2: adapter-class-property.patch --]
[-- Type: text/x-patch, Size: 1964 bytes --]
diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
index eb973ec..1e03b4e 100644
--- a/doc/adapter-api.txt
+++ b/doc/adapter-api.txt
@@ -210,6 +210,10 @@ Properties string Address [readonly]
The Bluetooth friendly name. This value can be
changed and a PropertyChanged signal will be emitted.
+ uint32 Class [readonly]
+
+ The Bluetooth class of device.
+
boolean Powered [readwrite]
Switch an adapter on or off. This will also set the
diff --git a/src/adapter.c b/src/adapter.c
index 52b58c4..c48ec68 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1192,6 +1192,7 @@ static DBusMessage *get_properties(DBusConnection *conn,
DBusMessageIter iter;
DBusMessageIter dict;
char str[249], srcaddr[18];
+ uint32_t class;
gboolean value;
char **devices;
int i;
@@ -1224,6 +1225,12 @@ static DBusMessage *get_properties(DBusConnection *conn,
dict_append_entry(&dict, "Name", DBUS_TYPE_STRING, &property);
+ /* Class */
+ class = adapter->dev.class[0]
+ | (adapter->dev.class[1] << 8)
+ | (adapter->dev.class[2] << 16);
+ dict_append_entry(&dict, "Class", DBUS_TYPE_UINT32, &class);
+
/* Powered */
value = adapter->up ? TRUE : FALSE;
dict_append_entry(&dict, "Powered", DBUS_TYPE_BOOLEAN, &value);
@@ -2326,6 +2333,8 @@ int adapter_get_class(struct btd_adapter *adapter, uint8_t *cls)
int adapter_set_class(struct btd_adapter *adapter, uint8_t *cls)
{
struct hci_dev *dev = &adapter->dev;
+ int dd;
+ uint32_t class;
if (memcmp(dev->class, cls, 3) == 0)
return 0;
@@ -2334,6 +2343,17 @@ int adapter_set_class(struct btd_adapter *adapter, uint8_t *cls)
write_local_class(&adapter->bdaddr, cls);
+ dd = hci_open_dev(adapter->dev_id);
+ if (dd >= 0) {
+ update_ext_inquiry_response(dd, dev);
+ hci_close_dev(dd);
+ }
+
+ class = cls[0] | (cls[1] << 8) | (cls[2] << 16);
+
+ emit_property_changed(connection, adapter->path, ADAPTER_INTERFACE,
+ "Class", DBUS_TYPE_UINT32, &class);
+
return 0;
}
next reply other threads:[~2009-03-04 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 1:09 Bea Lam [this message]
2009-03-04 21:04 ` [PATCH] Add "Class" property to org.bluez.Adapter Marcel Holtmann
2009-03-05 0:24 ` Bea Lam
2009-03-12 15:09 ` Johan Hedberg
2009-03-16 1:38 ` Bea Lam
2009-03-16 2:20 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ADD4C8.8040705@trolltech.com \
--to=bea.lam@trolltech.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox