* [PATCH] fix missing call to closedir
@ 2009-08-25 11:47 Vladimir Botka
2009-08-25 14:42 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Botka @ 2009-08-25 11:47 UTC (permalink / raw)
To: linux-bluetooth; +Cc: David Binderman
>From 29e477a29519c4a232ba02b6878beeeaa6d57da6 Mon Sep 17 00:00:00 2001
From: Vladimir Botka <vlado@dolby.suse.cz>
Date: Tue, 25 Aug 2009 13:23:29 +0200
Subject: [PATCH] fix missing call to closedir
---
compat/dun.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/compat/dun.c b/compat/dun.c
index c74e5ee..7140bac 100644
--- a/compat/dun.c
+++ b/compat/dun.c
@@ -106,8 +106,10 @@ static int uses_rfcomm(char *path, char *dev)
int len = readlink(de->d_name, link, sizeof(link));
if (len > 0) {
link[len] = 0;
- if (strstr(link, dev))
+ if (strstr(link, dev)) {
+ closedir(dir);
return 1;
+ }
}
}
--
1.6.0.2
Cheers,
--
-vlado
Vladimir Botka
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix missing call to closedir
2009-08-25 11:47 Vladimir Botka
@ 2009-08-25 14:42 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2009-08-25 14:42 UTC (permalink / raw)
To: Vladimir Botka; +Cc: linux-bluetooth, David Binderman
Hi Vladimir,
> From 29e477a29519c4a232ba02b6878beeeaa6d57da6 Mon Sep 17 00:00:00 2001
> From: Vladimir Botka <vlado@dolby.suse.cz>
> Date: Tue, 25 Aug 2009 13:23:29 +0200
> Subject: [PATCH] fix missing call to closedir
please fix your .gitconfig so we have real email addresses as author and
not some ones with machine names in it.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fix missing call to closedir
@ 2009-08-25 15:46 Vladimir Botka
2009-08-26 6:50 ` Marcel Holtmann
0 siblings, 1 reply; 4+ messages in thread
From: Vladimir Botka @ 2009-08-25 15:46 UTC (permalink / raw)
To: linux-bluetooth
>From 29e477a29519c4a232ba02b6878beeeaa6d57da6 Mon Sep 17 00:00:00 2001
From: Vladimir Botka <vbotka@gmail.com>
Date: Tue, 25 Aug 2009 13:23:29 +0200
Subject: [PATCH] fix missing call to closedir
---
compat/dun.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/compat/dun.c b/compat/dun.c
index c74e5ee..7140bac 100644
--- a/compat/dun.c
+++ b/compat/dun.c
@@ -106,8 +106,10 @@ static int uses_rfcomm(char *path, char *dev)
int len = readlink(de->d_name, link, sizeof(link));
if (len > 0) {
link[len] = 0;
- if (strstr(link, dev))
+ if (strstr(link, dev)) {
+ closedir(dir);
return 1;
+ }
}
}
--
1.6.0.2
Marcel, thank you for the hint. Sorry for the inconveniences.
Cheers,
--
-vlado
Vladimir Botka
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] fix missing call to closedir
2009-08-25 15:46 [PATCH] fix missing call to closedir Vladimir Botka
@ 2009-08-26 6:50 ` Marcel Holtmann
0 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2009-08-26 6:50 UTC (permalink / raw)
To: Vladimir Botka; +Cc: linux-bluetooth
Hi Vladimir,
> ---
> compat/dun.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-26 6:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-25 15:46 [PATCH] fix missing call to closedir Vladimir Botka
2009-08-26 6:50 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2009-08-25 11:47 Vladimir Botka
2009-08-25 14:42 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox