public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Fallback eSCO to SCO on error 0x1a (Unsupported Remote Feature).
@ 2010-02-03 19:42 Nick Pelly
  2010-02-03 20:06 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Pelly @ 2010-02-03 19:42 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Nick Pelly, Jaikumar Ganesh

General Motors carkits that use LGE BT chipsets return this error code when
an eSCO is attempted, despite advertising eSCO support.

2009-08-13 14:41:39.755518 < HCI Command: Setup Synchronous Connection (0x01|0x0028) plen 17
   handle 1 voice setting 0x0060
2009-08-13 14:41:39.757563 > HCI Event: Command Status (0x0f) plen 4
   Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
2009-08-13 14:41:39.789484 > HCI Event: Synchronous Connect Complete (0x2c) plen 17
   status 0x1a handle 257 bdaddr 00:1E:B2:23:5E:B3 type eSCO
   Error: Unsupported Remote Feature / Unsupported LMP Feature

Signed-off-by: Jaikumar Ganesh <jaikumar@google.com>
Signed-off-by: Nick Pelly <npelly@google.com>
---
 net/bluetooth/hci_event.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index e99fe38..8997a22 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1699,6 +1699,7 @@ static inline void hci_sync_conn_complete_evt(struct hci_dev *hdev, struct sk_bu
 		break;
 
 	case 0x1c:	/* SCO interval rejected */
+	case 0x1a:	/* Unsupported Remote Feature */
 	case 0x1f:	/* Unspecified error */
 		if (conn->out && conn->attempt < 2) {
 			conn->pkt_type = (hdev->esco_type & SCO_ESCO_MASK) |
-- 
1.6.5.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: Fallback eSCO to SCO on error 0x1a (Unsupported Remote Feature).
  2010-02-03 19:42 [PATCH] Bluetooth: Fallback eSCO to SCO on error 0x1a (Unsupported Remote Feature) Nick Pelly
@ 2010-02-03 20:06 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2010-02-03 20:06 UTC (permalink / raw)
  To: Nick Pelly; +Cc: linux-bluetooth, Jaikumar Ganesh

Hi Nick,

> General Motors carkits that use LGE BT chipsets return this error code when
> an eSCO is attempted, despite advertising eSCO support.
> 
> 2009-08-13 14:41:39.755518 < HCI Command: Setup Synchronous Connection (0x01|0x0028) plen 17
>    handle 1 voice setting 0x0060
> 2009-08-13 14:41:39.757563 > HCI Event: Command Status (0x0f) plen 4
>    Setup Synchronous Connection (0x01|0x0028) status 0x00 ncmd 1
> 2009-08-13 14:41:39.789484 > HCI Event: Synchronous Connect Complete (0x2c) plen 17
>    status 0x1a handle 257 bdaddr 00:1E:B2:23:5E:B3 type eSCO
>    Error: Unsupported Remote Feature / Unsupported LMP Feature
> 
> Signed-off-by: Jaikumar Ganesh <jaikumar@google.com>
> Signed-off-by: Nick Pelly <npelly@google.com>

I applied this patch to the bluetooth-2.6 tree. Thanks.

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-03 20:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-03 19:42 [PATCH] Bluetooth: Fallback eSCO to SCO on error 0x1a (Unsupported Remote Feature) Nick Pelly
2010-02-03 20:06 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox