obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hello

This is a regression over obexd-0.21. After updating to 0.22,
gnome-bluetooth sendto dialog no longer closes when operation finishes,
even if file is already properly sent.

This has been reported also in:
https://bugzilla.gnome.org/show_bug.cgi?id=613196

Thanks a lot for your help

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

[Vinicius Gomes]

Hi Pacho,

2010/4/10 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> Hello
>
> This is a regression over obexd-0.21. After updating to 0.22,
> gnome-bluetooth sendto dialog no longer closes when operation finishes,
> even if file is already properly sent.
>

We noticed this regression as well. Luiz already has a fix for this,
it was just not integrated yet.

In case you want to take a look and perhaps help test it, the fix is here[1].


Cheers,
-- 
Vinicius


[1] http://gitorious.org/~vudentz/obexd/vudentzs-clone (branch master)

Re: obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

El sáb, 10-04-2010 a las 11:17 -0300, Vinicius Gomes escribió:
> Hi Pacho,
> 
> 2010/4/10 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> > Hello
> >
> > This is a regression over obexd-0.21. After updating to 0.22,
> > gnome-bluetooth sendto dialog no longer closes when operation finishes,
> > even if file is already properly sent.
> >
> 
> We noticed this regression as well. Luiz already has a fix for this,
> it was just not integrated yet.
> 
> In case you want to take a look and perhaps help test it, the fix is here[1].
> 
> 
> Cheers,

Thanks a lot, I will try to use it as soon as I am able to

Best regards

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

[Bastien Nocera]

On Sat, 2010-04-10 at 11:17 -0300, Vinicius Gomes wrote:
> Hi Pacho,
> 
> 2010/4/10 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
> > Hello
> >
> > This is a regression over obexd-0.21. After updating to 0.22,
> > gnome-bluetooth sendto dialog no longer closes when operation finishes,
> > even if file is already properly sent.
> >
> 
> We noticed this regression as well. Luiz already has a fix for this,
> it was just not integrated yet.
> 
> In case you want to take a look and perhaps help test it, the fix is here[1].

Except that the patch is absolutely huge, and doesn't apply cleanly on
0.22 either.

Re: obexd-0.22 causes gnome-bluetooth sendto dialog to stop closing when operation ends

[Luiz Augusto von Dentz]

Hi,

On Mon, Apr 12, 2010 at 6:22 PM, Bastien Nocera <hadess@hadess.net> wrote:
> On Sat, 2010-04-10 at 11:17 -0300, Vinicius Gomes wrote:
>> Hi Pacho,
>>
>> 2010/4/10 Pacho Ramos <pacho@condmat1.ciencias.uniovi.es>:
>> > Hello
>> >
>> > This is a regression over obexd-0.21. After updating to 0.22,
>> > gnome-bluetooth sendto dialog no longer closes when operation finishes,
>> > even if file is already properly sent.
>> >
>>
>> We noticed this regression as well. Luiz already has a fix for this,
>> it was just not integrated yet.
>>
>> In case you want to take a look and perhaps help test it, the fix is here[1].
>
> Except that the patch is absolutely huge, and doesn't apply cleanly on
> 0.22 either.

For those wanting to have a quick fix for 0.22 you can revert
d57bffe46b71e17a640c11b389dd6da95f933729, which cause the extra
reference to be hold. In the meantime I will be doing some cleanups to
session code and moving the transfer logic to a separate file those
changes will probably be only available in 0.23.

-- 
Luiz Augusto von Dentz
Computer Engineer