Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: linux-bluetooth@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro  6,2 and 7,1
Date: Sun, 01 Aug 2010 16:47:46 -0700	[thread overview]
Message-ID: <1280706466.12579.11.camel@localhost.localdomain> (raw)
In-Reply-To: <AANLkTimcf8nmrad8BP8aLw4OefAr1vNZANNRf7rPMrrG@mail.gmail.com>

Hi Nobuhiro,

> Bluetooth controller of Macbook Pro 6,2 and 7,1 does not work.
> Because Device Class of these controllers was set 255 (Vendor Sepecific Class).
> 
> Macbook Pro 7,1 :
> Bus 004 Device 005: ID 05ac:8213 Apple, Inc.
> Device Descriptor:
>   bLength                18
>   bDescriptorType         1
>   bcdUSB               2.00
>   bDeviceClass          255 Vendor Specific Class
>   bDeviceSubClass         1
>   bDeviceProtocol         1
>   bMaxPacketSize0        64
>   idVendor           0x05ac Apple, Inc.
>   idProduct          0x8213
>   bcdDevice            1.86
>   iManufacturer           1 Apple Inc.
>   iProduct                2 Bluetooth USB Host Controller
>   iSerial                 3 5C5948C81B99
>   bNumConfigurations      1

I prefer the details of /proc/bus/usb/devices or usb-devices.sh script.
And I do prefer one patch with it for each MacBook.

> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/bluetooth/btusb.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5d9cc53..00a6639 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -75,6 +75,12 @@ static struct usb_device_id btusb_table[] = {
>  	/* Canyon CN-BTU1 with HID interfaces */
>  	{ USB_DEVICE(0x0c10, 0x0000) },
> 
> +	/* Apple MacBookPro 6,2 */
> +	{ USB_DEVICE(0x05ac, 0x8218) },
> +
> +	/* Apple MacBookPro 7,2 */
> +	{ USB_DEVICE(0x05ac, 0x8213) },
> +
>  	{ }	/* Terminating entry */
>  };

Please sort them along the entry for the iMac11,1 and make sure it is
smaller PID first.

Regards

Marcel



      reply	other threads:[~2010-08-01 23:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-01 21:23 [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro 6,2 and 7,1 Nobuhiro Iwamatsu
2010-08-01 23:47 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280706466.12579.11.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=iwamatsu@nigauri.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox