Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro 6,2 and 7,1
@ 2010-08-01 21:23 Nobuhiro Iwamatsu
  2010-08-01 23:47 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Nobuhiro Iwamatsu @ 2010-08-01 21:23 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: stable

Bluetooth controller of Macbook Pro 6,2 and 7,1 does not work.
Because Device Class of these controllers was set 255 (Vendor Sepecific Class).

Macbook Pro 7,1 :
Bus 004 Device 005: ID 05ac:8213 Apple, Inc.
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.00
  bDeviceClass          255 Vendor Specific Class
  bDeviceSubClass         1
  bDeviceProtocol         1
  bMaxPacketSize0        64
  idVendor           0x05ac Apple, Inc.
  idProduct          0x8213
  bcdDevice            1.86
  iManufacturer           1 Apple Inc.
  iProduct                2 Bluetooth USB Host Controller
  iSerial                 3 5C5948C81B99
  bNumConfigurations      1

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 drivers/bluetooth/btusb.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 5d9cc53..00a6639 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -75,6 +75,12 @@ static struct usb_device_id btusb_table[] = {
 	/* Canyon CN-BTU1 with HID interfaces */
 	{ USB_DEVICE(0x0c10, 0x0000) },

+	/* Apple MacBookPro 6,2 */
+	{ USB_DEVICE(0x05ac, 0x8218) },
+
+	/* Apple MacBookPro 7,2 */
+	{ USB_DEVICE(0x05ac, 0x8213) },
+
 	{ }	/* Terminating entry */
 };

-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro  6,2 and 7,1
  2010-08-01 21:23 [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro 6,2 and 7,1 Nobuhiro Iwamatsu
@ 2010-08-01 23:47 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2010-08-01 23:47 UTC (permalink / raw)
  To: Nobuhiro Iwamatsu; +Cc: linux-bluetooth, stable

Hi Nobuhiro,

> Bluetooth controller of Macbook Pro 6,2 and 7,1 does not work.
> Because Device Class of these controllers was set 255 (Vendor Sepecific Class).
> 
> Macbook Pro 7,1 :
> Bus 004 Device 005: ID 05ac:8213 Apple, Inc.
> Device Descriptor:
>   bLength                18
>   bDescriptorType         1
>   bcdUSB               2.00
>   bDeviceClass          255 Vendor Specific Class
>   bDeviceSubClass         1
>   bDeviceProtocol         1
>   bMaxPacketSize0        64
>   idVendor           0x05ac Apple, Inc.
>   idProduct          0x8213
>   bcdDevice            1.86
>   iManufacturer           1 Apple Inc.
>   iProduct                2 Bluetooth USB Host Controller
>   iSerial                 3 5C5948C81B99
>   bNumConfigurations      1

I prefer the details of /proc/bus/usb/devices or usb-devices.sh script.
And I do prefer one patch with it for each MacBook.

> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/bluetooth/btusb.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 5d9cc53..00a6639 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -75,6 +75,12 @@ static struct usb_device_id btusb_table[] = {
>  	/* Canyon CN-BTU1 with HID interfaces */
>  	{ USB_DEVICE(0x0c10, 0x0000) },
> 
> +	/* Apple MacBookPro 6,2 */
> +	{ USB_DEVICE(0x05ac, 0x8218) },
> +
> +	/* Apple MacBookPro 7,2 */
> +	{ USB_DEVICE(0x05ac, 0x8213) },
> +
>  	{ }	/* Terminating entry */
>  };

Please sort them along the entry for the iMac11,1 and make sure it is
smaller PID first.

Regards

Marcel



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-01 23:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-01 21:23 [PATCH] bluetooth: Add support Bluetooth controller of Macbook Pro 6,2 and 7,1 Nobuhiro Iwamatsu
2010-08-01 23:47 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox