Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH v2] Fix endian conversion for appparams in pbap client
@ 2011-05-15 10:37 Bartosz Szatkowski
  2011-05-15 11:49 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Szatkowski @ 2011-05-15 10:37 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Bartosz Szatkowski

---
 client/pbap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/pbap.c b/client/pbap.c
index 837419c..589b1ca 100644
--- a/client/pbap.c
+++ b/client/pbap.c
@@ -312,7 +312,7 @@ static void read_return_apparam(struct session_data *session,
 			if (hdr->len == PHONEBOOKSIZE_LEN) {
 				guint16 val;
 				memcpy(&val, hdr->val, sizeof(val));
-				*phone_book_size = val;
+				*phone_book_size = get_be16(&val);
 			}
 			break;
 		case NEWMISSEDCALLS_TAG:
-- 
1.7.5.rc3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Fix endian conversion for appparams in pbap client
  2011-05-15 10:37 [PATCH v2] Fix endian conversion for appparams in pbap client Bartosz Szatkowski
@ 2011-05-15 11:49 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-05-15 11:49 UTC (permalink / raw)
  To: Bartosz Szatkowski; +Cc: linux-bluetooth

Hi Bartosz,

On Sun, May 15, 2011, Bartosz Szatkowski wrote:
> ---
>  client/pbap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/client/pbap.c b/client/pbap.c
> index 837419c..589b1ca 100644
> --- a/client/pbap.c
> +++ b/client/pbap.c
> @@ -312,7 +312,7 @@ static void read_return_apparam(struct session_data *session,
>  			if (hdr->len == PHONEBOOKSIZE_LEN) {
>  				guint16 val;
>  				memcpy(&val, hdr->val, sizeof(val));
> -				*phone_book_size = val;
> +				*phone_book_size = get_be16(&val);
>  			}
>  			break;
>  		case NEWMISSEDCALLS_TAG:

Pushed upstream. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-15 11:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-15 10:37 [PATCH v2] Fix endian conversion for appparams in pbap client Bartosz Szatkowski
2011-05-15 11:49 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox