From: Marcel Holtmann <marcel@holtmann.org>
To: hui li <nami.li1984@gmail.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"haijun.liu" <haijun.liu@atheros.com>,
steven.li@atheros.com, ruiyi.zhang@atheros.com,
yang.wu@atheros.com, costa.yao@atheros.com, nami.li@atheros.com
Subject: Re: bluez patch : Modify OPUSH sdp record when use sdptool for GOEP v2.0
Date: Fri, 20 May 2011 11:42:09 -0700 [thread overview]
Message-ID: <1305916929.2681.12.camel@aeonflux> (raw)
In-Reply-To: <BANLkTi=V_s9UjZ19qk-jivF=0wzPk9XYbA@mail.gmail.com>
Hi Hui,
> Since GOEP v2.0 has some changes in sdp record, I`d like to add the
> two changes in bluez for backwards compatibility with GOEP v1.x:
> • The profile version number in the BluetoothProfileDescriptorList
> attribute shall be incremented to match the version number of the
> enhanced profile specification. If earlier versions of the profile do
> not include this SDP attribute it shall be included in revised
> versions.
> • The SDP records shall include the GoepL2capPsm attribute.
>
> The upper text references Generic Object Exchange Profile v2.0.
> The GoepL2capPsm attribute value can be found in Bluetooth SIG
> Assigned Numbers – Service Discovery, and this value is 0x0200.
>
> My patch only define GoepL2capPsm and change OPUSH sdp record in
> sdptool. I didn`t assign a new variable in svc_info_t struct to
> indicate the new l2cap psm value, I used its original psm member to
> indicate l2cap psm value.
> Also, I didn`t found OPUSH l2cap psm default value in Bluetooth SIG
> Assigned Numbers or its spec, so I just choose 0x1015 as its default
> value.
please do not update opush record details since we are using that one
for qualification and I don't wanna redo all my SDP data.
Just add an opush2 command to sdptool to add a GOEP 2.0 SDP record.
Regards
Marcel
next prev parent reply other threads:[~2011-05-20 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 9:03 bluez patch : Modify OPUSH sdp record when use sdptool for GOEP v2.0 hui li
2011-05-20 18:42 ` Marcel Holtmann [this message]
2011-05-20 19:40 ` Luiz Augusto von Dentz
2011-05-23 7:05 ` hui li
2011-05-23 18:14 ` Marcel Holtmann
2011-05-24 3:54 ` hui li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305916929.2681.12.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=costa.yao@atheros.com \
--cc=haijun.liu@atheros.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=nami.li1984@gmail.com \
--cc=nami.li@atheros.com \
--cc=ruiyi.zhang@atheros.com \
--cc=steven.li@atheros.com \
--cc=yang.wu@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox