Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: hui li <nami.li1984@gmail.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	"haijun.liu" <haijun.liu@atheros.com>,
	steven.li@atheros.com, ruiyi.zhang@atheros.com,
	yang.wu@atheros.com, costa.yao@atheros.com, nami.li@atheros.com
Subject: Re: bluez patch : Modify OPUSH sdp record when use sdptool for GOEP v2.0
Date: Mon, 23 May 2011 11:14:06 -0700	[thread overview]
Message-ID: <1306174446.2681.15.camel@aeonflux> (raw)
In-Reply-To: <BANLkTimpsOoibrke0-v8tRSTpaZr1imJWQ@mail.gmail.com>

Hi Hui,

>     So you  mean you don`t wanna to change currently add_opush
> ,add_ftp and other obex services functions code?
> I think instead of opush2, we can add a new goep2 command commonly to
> sdptool to update service record like below:
> 
>  sdptool goep2 l2cappsm SERVICE
> 
> And in cmd_goep2 function, I first get that service original sdp
> record, then update profile version, add new GoepL2capPsm attribute ,
> and finally update that service record.
> How do you think about this way ? It doesn`t influnce original command
> and fuctions. If ok, I will send out my patch.

just to make one thing perfectly clear here. The sdptool should only be
used for testing. So you can do something like:

	sdptool add --psm 2 opush

And only create the extra GOEP 2.0 if the --psm switch is given. However
it is not acceptable that you break the current behavior.

Regards

Marcel



  reply	other threads:[~2011-05-23 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18  9:03 bluez patch : Modify OPUSH sdp record when use sdptool for GOEP v2.0 hui li
2011-05-20 18:42 ` Marcel Holtmann
2011-05-20 19:40   ` Luiz Augusto von Dentz
2011-05-23  7:05     ` hui li
2011-05-23 18:14       ` Marcel Holtmann [this message]
2011-05-24  3:54         ` hui li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306174446.2681.15.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=costa.yao@atheros.com \
    --cc=haijun.liu@atheros.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=nami.li1984@gmail.com \
    --cc=nami.li@atheros.com \
    --cc=ruiyi.zhang@atheros.com \
    --cc=steven.li@atheros.com \
    --cc=yang.wu@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox