Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Fix coding style issue regarding with pointer checks
@ 2011-11-17 10:24 Santiago Carot-Nemesio
  2011-11-17 12:00 ` Johan Hedberg
  0 siblings, 1 reply; 2+ messages in thread
From: Santiago Carot-Nemesio @ 2011-11-17 10:24 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Santiago Carot-Nemesio

---
 attrib/gatt-service.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/attrib/gatt-service.c b/attrib/gatt-service.c
index 3199830..ead3f8e 100644
--- a/attrib/gatt-service.c
+++ b/attrib/gatt-service.c
@@ -214,7 +214,7 @@ static gboolean add_characteristic(uint16_t *handle, struct gatt_info *info)
 		}
 	}
 
-	if (info->value_handle)
+	if (info->value_handle != NULL)
 		*info->value_handle = a->handle;
 
 	/* client characteristic configuration descriptor */
@@ -227,7 +227,7 @@ static gboolean add_characteristic(uint16_t *handle, struct gatt_info *info)
 		a = attrib_db_add(h++, &bt_uuid, ATT_NONE, ATT_AUTHENTICATION,
 						cfg_val, sizeof(cfg_val));
 
-		if (info->ccc_handle)
+		if (info->ccc_handle != NULL)
 			*info->ccc_handle = a->handle;
 	}
 
-- 
1.7.7.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix coding style issue regarding with pointer checks
  2011-11-17 10:24 [PATCH] Fix coding style issue regarding with pointer checks Santiago Carot-Nemesio
@ 2011-11-17 12:00 ` Johan Hedberg
  0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-11-17 12:00 UTC (permalink / raw)
  To: Santiago Carot-Nemesio; +Cc: linux-bluetooth

Hi Santiago,

On Thu, Nov 17, 2011, Santiago Carot-Nemesio wrote:
> ---
>  attrib/gatt-service.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Applied. Thanks.

Johan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-17 12:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 10:24 [PATCH] Fix coding style issue regarding with pointer checks Santiago Carot-Nemesio
2011-11-17 12:00 ` Johan Hedberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox