Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com
Subject: Re: [PATCH 2/2] Bluetooth: l2cap_set_timer needs jiffies as timeout value
Date: Wed, 04 Jan 2012 07:46:16 -0800	[thread overview]
Message-ID: <1325691976.6454.30.camel@aeonflux> (raw)
In-Reply-To: <1325675442-24658-3-git-send-email-andrzej.kaczmarek@tieto.com>

Hi Andrzej,

> After moving L2CAP timers to workqueues l2cap_set_timer expects timeout
> value to be specified in jiffies but constants defined in miliseconds
> are used. This makes timeouts unreliable when CONFIG_HZ is not set to
> 1000.
> 
> __set_chan_timer macro still uses jiffies as input to avoid multiple
> conversions from/to jiffies for sk_sndtimeo value which is already
> specified in jiffies.
> 
> Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
> ---
>  include/net/bluetooth/l2cap.h |    6 +++---
>  net/bluetooth/l2cap_core.c    |   12 ++++++++----
>  2 files changed, 11 insertions(+), 7 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  reply	other threads:[~2012-01-04 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 11:10 [PATCH 0/2] Fix L2CAP timeout values Andrzej Kaczmarek
2012-01-04 11:10 ` [PATCH 1/2] Bluetooth: Fix sk_sndtimeo initialization for L2CAP socket Andrzej Kaczmarek
2012-01-04 15:44   ` Marcel Holtmann
2012-01-04 11:10 ` [PATCH 2/2] Bluetooth: l2cap_set_timer needs jiffies as timeout value Andrzej Kaczmarek
2012-01-04 15:46   ` Marcel Holtmann [this message]
2012-01-08 20:29 ` [PATCH 0/2] Fix L2CAP timeout values Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325691976.6454.30.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=andrzej.kaczmarek@tieto.com \
    --cc=kanak.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox