Linux bluetooth development
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrzej Kaczmarek <andrzej.kaczmarek@tieto.com>
Cc: linux-bluetooth@vger.kernel.org, kanak.gupta@stericsson.com
Subject: Re: [PATCH 0/2] Fix L2CAP timeout values
Date: Sun, 8 Jan 2012 22:29:46 +0200	[thread overview]
Message-ID: <20120108202946.GD16731@x220.P-661HNU-F1> (raw)
In-Reply-To: <1325675442-24658-1-git-send-email-andrzej.kaczmarek@tieto.com>

Hi Andrzej,

On Wed, Jan 04, 2012, Andrzej Kaczmarek wrote:
> After moving L2CAP timers to workqueues there is problem with timeout
> values which are defined in miliseconds but timer functions works with
> jiffies. As a result, timers are unreliable on platforms with CONFIG_HZ
> not set to 1000.
> 
> Similar problem was fixed before workqueues but now it's apparently
> back. This time however I left l2ca_set_timer to use values in jiffies
> to avoid confusion and make code less prone to similar issues in
> future (I hope).
> 
> Also together with patch from Peter Hurley it should fix problems with
> SSP and RFCOMM as recently discovered (on platforms with
> CONFIG_HZ != 1000).
> 
> Andrzej Kaczmarek (2):
>   Bluetooth: Fix sk_sndtimeo initialization for L2CAP socket
>   Bluetooth: l2cap_set_timer needs jiffies as timeout value
> 
>  include/net/bluetooth/l2cap.h |    6 +++---
>  net/bluetooth/l2cap_core.c    |   12 ++++++++----
>  net/bluetooth/l2cap_sock.c    |    2 +-
>  3 files changed, 12 insertions(+), 8 deletions(-)

Both patches have been applied to my bluetooth-next tree. Thanks.

Johan

      parent reply	other threads:[~2012-01-08 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 11:10 [PATCH 0/2] Fix L2CAP timeout values Andrzej Kaczmarek
2012-01-04 11:10 ` [PATCH 1/2] Bluetooth: Fix sk_sndtimeo initialization for L2CAP socket Andrzej Kaczmarek
2012-01-04 15:44   ` Marcel Holtmann
2012-01-04 11:10 ` [PATCH 2/2] Bluetooth: l2cap_set_timer needs jiffies as timeout value Andrzej Kaczmarek
2012-01-04 15:46   ` Marcel Holtmann
2012-01-08 20:29 ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120108202946.GD16731@x220.P-661HNU-F1 \
    --to=johan.hedberg@gmail.com \
    --cc=andrzej.kaczmarek@tieto.com \
    --cc=kanak.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox