From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv4 25/30] Bluetooth: A2MP: Handling fixed channels
Date: Thu, 15 Mar 2012 14:30:16 +0200 [thread overview]
Message-ID: <1331814621-13905-26-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1331814621-13905-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
A2MP fixed channel do not have sk
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
include/net/bluetooth/l2cap.h | 1 +
net/bluetooth/a2mp.c | 4 ++--
net/bluetooth/l2cap_core.c | 15 +++++++++++++--
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index b3f9854..15c0f03 100644
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -557,6 +557,7 @@ struct l2cap_conn {
#define L2CAP_CHAN_RAW 1
#define L2CAP_CHAN_CONN_LESS 2
#define L2CAP_CHAN_CONN_ORIENTED 3
+#define L2CAP_CHAN_CONN_FIX_A2MP 4
/* ----- L2CAP socket info ----- */
#define l2cap_pi(sk) ((struct l2cap_pinfo *) sk)
diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index 0ef69de..7709fcd 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -433,9 +433,9 @@ static struct l2cap_chan *open_a2mp_chan(struct l2cap_conn *conn)
BT_DBG("chan %p", chan);
+ chan->chan_type = L2CAP_CHAN_CONN_FIX_A2MP;
+
chan->sec_level = BT_SECURITY_LOW;
- chan->omtu = L2CAP_A2MP_DEFAULT_MTU;
- chan->imtu = L2CAP_A2MP_DEFAULT_MTU;
chan->flush_to = L2CAP_DEFAULT_FLUSH_TO;
chan->fcs = L2CAP_FCS_CRC16;
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index e8855cc..d840aae 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -333,6 +333,13 @@ static void __l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
chan->omtu = L2CAP_DEFAULT_MTU;
break;
+ case L2CAP_CHAN_CONN_FIX_A2MP:
+ chan->scid = L2CAP_CID_A2MP;
+ chan->dcid = L2CAP_CID_A2MP;
+ chan->omtu = L2CAP_A2MP_DEFAULT_MTU;
+ chan->imtu = L2CAP_A2MP_DEFAULT_MTU;
+ break;
+
default:
/* Raw socket can send/recv signalling messages only */
chan->scid = L2CAP_CID_SIGNALING;
@@ -363,7 +370,7 @@ static void l2cap_chan_del(struct l2cap_chan *chan, int err)
{
struct sock *sk = chan->sk;
struct l2cap_conn *conn = chan->conn;
- struct sock *parent = bt_sk(sk)->parent;
+ struct sock *parent;
__clear_chan_timer(chan);
@@ -379,12 +386,15 @@ static void l2cap_chan_del(struct l2cap_chan *chan, int err)
hci_conn_put(conn->hcon);
}
+ if (chan->chan_type == L2CAP_CHAN_CONN_FIX_A2MP)
+ goto clean;
+
lock_sock(sk);
__l2cap_state_change(chan, BT_CLOSED, err);
-
sock_set_flag(sk, SOCK_ZAPPED);
+ parent = bt_sk(sk)->parent;
if (parent) {
bt_accept_unlink(sk);
parent->sk_data_ready(parent, 0);
@@ -397,6 +407,7 @@ static void l2cap_chan_del(struct l2cap_chan *chan, int err)
test_bit(CONF_INPUT_DONE, &chan->conf_state)))
return;
+clean:
skb_queue_purge(&chan->tx_q);
if (chan->mode == L2CAP_MODE_ERTM) {
--
1.7.9.1
next prev parent reply other threads:[~2012-03-15 12:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 12:29 [RFCv4 00/30] RFC Bluetooth A2MP implementation Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 01/30] Bluetooth: Make ertm_init available Andrei Emeltchenko
2012-03-20 3:04 ` Gustavo Padovan
2012-03-20 8:03 ` Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 02/30] Bluetooth: Add send function to chan ops Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 03/30] Bluetooth: Make l2cap_chan_add available Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 04/30] Bluetooth: Add set_err to state_change callback Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 05/30] Bluetooth: Lock sk only if exist Andrei Emeltchenko
2012-03-20 3:03 ` Gustavo Padovan
2012-03-20 12:22 ` Ulisses Furquim
2012-03-20 12:49 ` Andrei Emeltchenko
2012-03-20 12:52 ` Ulisses Furquim
2012-03-15 12:29 ` [RFCv4 06/30] Bluetooth: Timers fixes Andrei Emeltchenko
2012-03-20 3:10 ` Gustavo Padovan
2012-03-20 12:21 ` Ulisses Furquim
2012-03-20 13:00 ` Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 07/30] Bluetooth: A2MP: Create A2MP channel Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 08/30] Bluetooth: A2MP: AMP Manager basic functions Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 09/30] Bluetooth: A2MP: Add channel close callback Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 10/30] Bluetooth: Add state_change for A2MP channel Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 11/30] Bluetooth: A2MP: Build and Send msg helpers Andrei Emeltchenko
2012-03-17 23:12 ` Gustavo Padovan
2012-03-15 12:30 ` [RFCv4 12/30] Bluetooth: A2MP: skb allocation callback Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 13/30] Bluetooth: A2MP: Definitions for A2MP commands Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 14/30] Bluetooth: A2MP: Define A2MP status codes Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 15/30] Bluetooth: A2MP: Process A2MP messages Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 16/30] Bluetooth: A2MP: Process A2MP Command Reject Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 17/30] Bluetooth: A2MP: Helper functions to count HCI devs Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 18/30] Bluetooth: A2MP: Process A2MP Discover Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 19/30] Bluetooth: A2MP: Process A2MP Change Notify Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 20/30] Bluetooth: A2MP: Process A2MP Get Info Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 21/30] Bluetooth: A2MP: Process A2MP Get AMP Assoc Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 22/30] Bluetooth: A2MP: Process A2MP Create Physlink Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 23/30] Bluetooth: A2MP: Process A2MP Disc " Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 24/30] Bluetooth: A2MP: Process A2MP Command Responses Andrei Emeltchenko
2012-03-15 12:30 ` Andrei Emeltchenko [this message]
2012-03-15 12:30 ` [RFCv4 26/30] Bluetooth: A2MP: Manage incoming connections Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 27/30] Bluetooth: physical link HCI interface to AMP Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 28/30] Bluetooth: Define AMP controller statuses Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 29/30] Bluetooth: General HCI callback implementation Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 30/30] Bluetooth: Process HCI callbacks in a workqueue Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331814621-13905-26-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox