From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv4 30/30] Bluetooth: Process HCI callbacks in a workqueue
Date: Thu, 15 Mar 2012 14:30:21 +0200 [thread overview]
Message-ID: <1331814621-13905-31-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1331814621-13905-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Conflicts:
include/net/bluetooth/hci_core.h
net/bluetooth/hci_core.c
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
include/net/bluetooth/hci_core.h | 2 +
net/bluetooth/hci_core.c | 41 ++++++++++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 9dd93d2..a774712 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -1105,5 +1105,7 @@ int hci_cmd_cb(struct hci_dev *hdev, __u16 opcode, __u32 plen, void *param,
void (*cb)(struct hci_dev *hdev, struct hci_cb_cmd *cmd), void *opt,
void (*destructor)(struct hci_cb_cmd *cmd), gfp_t flags);
void hci_remove_cb(struct hci_dev *hdev, struct hci_cb_cmd *cmd);
+void hci_queue_cb(struct hci_dev *hdev, struct hci_cb_cmd *cmd,
+ struct workqueue_struct *workqueue);
#endif /* __HCI_CORE_H */
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index d8b443b..438486e 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2278,6 +2278,47 @@ struct hci_cb_cmd *hci_find_cb(struct hci_dev *hdev, __u16 opcode)
return NULL;
}
+struct hci_cb_work {
+ struct work_struct work;
+ struct hci_dev *hdev;
+ struct hci_cb_cmd *cmd;
+};
+
+static void hci_cb_worker(struct work_struct *w)
+{
+ struct hci_cb_work *work = (struct hci_cb_work *) w;
+ struct hci_cb_cmd *cmd = work->cmd;
+ struct hci_dev *hdev = work->hdev;
+
+ cmd->cb(hdev, cmd);
+
+ hci_remove_cb(hdev, cmd);
+ kfree(w);
+ hci_dev_put(hdev);
+}
+
+void hci_queue_cb(struct hci_dev *hdev, struct hci_cb_cmd *cmd,
+ struct workqueue_struct *workqueue)
+{
+ struct hci_cb_work *work;
+
+ BT_DBG("Queue cmd %p opt %p", cmd, cmd->opt);
+
+ work = kmalloc(sizeof(*work), GFP_KERNEL);
+ if (!work)
+ return;
+
+ INIT_WORK(&work->work, hci_cb_worker);
+ work->hdev = hdev;
+ work->cmd = cmd;
+ hci_dev_hold(hdev);
+
+ if (!queue_work(workqueue, &work->work)) {
+ kfree(work);
+ hci_dev_put(hdev);
+ }
+}
+
void hci_remove_cb(struct hci_dev *hdev, struct hci_cb_cmd *cmd)
{
mutex_lock(&hdev->cb_list_lock);
--
1.7.9.1
prev parent reply other threads:[~2012-03-15 12:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 12:29 [RFCv4 00/30] RFC Bluetooth A2MP implementation Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 01/30] Bluetooth: Make ertm_init available Andrei Emeltchenko
2012-03-20 3:04 ` Gustavo Padovan
2012-03-20 8:03 ` Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 02/30] Bluetooth: Add send function to chan ops Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 03/30] Bluetooth: Make l2cap_chan_add available Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 04/30] Bluetooth: Add set_err to state_change callback Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 05/30] Bluetooth: Lock sk only if exist Andrei Emeltchenko
2012-03-20 3:03 ` Gustavo Padovan
2012-03-20 12:22 ` Ulisses Furquim
2012-03-20 12:49 ` Andrei Emeltchenko
2012-03-20 12:52 ` Ulisses Furquim
2012-03-15 12:29 ` [RFCv4 06/30] Bluetooth: Timers fixes Andrei Emeltchenko
2012-03-20 3:10 ` Gustavo Padovan
2012-03-20 12:21 ` Ulisses Furquim
2012-03-20 13:00 ` Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 07/30] Bluetooth: A2MP: Create A2MP channel Andrei Emeltchenko
2012-03-15 12:29 ` [RFCv4 08/30] Bluetooth: A2MP: AMP Manager basic functions Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 09/30] Bluetooth: A2MP: Add channel close callback Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 10/30] Bluetooth: Add state_change for A2MP channel Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 11/30] Bluetooth: A2MP: Build and Send msg helpers Andrei Emeltchenko
2012-03-17 23:12 ` Gustavo Padovan
2012-03-15 12:30 ` [RFCv4 12/30] Bluetooth: A2MP: skb allocation callback Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 13/30] Bluetooth: A2MP: Definitions for A2MP commands Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 14/30] Bluetooth: A2MP: Define A2MP status codes Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 15/30] Bluetooth: A2MP: Process A2MP messages Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 16/30] Bluetooth: A2MP: Process A2MP Command Reject Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 17/30] Bluetooth: A2MP: Helper functions to count HCI devs Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 18/30] Bluetooth: A2MP: Process A2MP Discover Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 19/30] Bluetooth: A2MP: Process A2MP Change Notify Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 20/30] Bluetooth: A2MP: Process A2MP Get Info Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 21/30] Bluetooth: A2MP: Process A2MP Get AMP Assoc Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 22/30] Bluetooth: A2MP: Process A2MP Create Physlink Request Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 23/30] Bluetooth: A2MP: Process A2MP Disc " Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 24/30] Bluetooth: A2MP: Process A2MP Command Responses Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 25/30] Bluetooth: A2MP: Handling fixed channels Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 26/30] Bluetooth: A2MP: Manage incoming connections Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 27/30] Bluetooth: physical link HCI interface to AMP Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 28/30] Bluetooth: Define AMP controller statuses Andrei Emeltchenko
2012-03-15 12:30 ` [RFCv4 29/30] Bluetooth: General HCI callback implementation Andrei Emeltchenko
2012-03-15 12:30 ` Andrei Emeltchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331814621-13905-31-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox