[PATCH] bluetooth: properly use pr_fmt() on lib.c

[PATCH] bluetooth: properly use pr_fmt() on lib.c

[Luis R. Rodriguez]

From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>

pr_fmt() is either defined or we redefine it. Typically
drivers define it prior to including printk.h but this
is done under the assumption that no other subsystem
it uses has already defined pr_fmt(). In such cases
pr_fmt() should be undefined and redefined.

Doing this properly shaves down compilation time quite
considerably.

Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
---
 net/bluetooth/lib.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/bluetooth/lib.c b/net/bluetooth/lib.c
index 5066288..84ff96f 100644
--- a/net/bluetooth/lib.c
+++ b/net/bluetooth/lib.c
@@ -24,11 +24,13 @@
 
 /* Bluetooth kernel library. */
 
+#undef pr_fmt
 #define pr_fmt(fmt) "Bluetooth: " fmt
 
 #include <linux/module.h>
 
 #include <linux/kernel.h>
+#include <linux/printk.h>
 #include <linux/stddef.h>
 #include <linux/string.h>
 #include <asm/errno.h>
-- 
1.7.10.rc1.22.gf5241

Re: [PATCH] bluetooth: properly use pr_fmt() on lib.c

[Gustavo Padovan]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Luiz,

* Luis R. Rodriguez <mcgrof@do-not-panic.com> [2012-04-23 19:45:06 -0700]:

> From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
> 
> pr_fmt() is either defined or we redefine it. Typically
> drivers define it prior to including printk.h but this
> is done under the assumption that no other subsystem
> it uses has already defined pr_fmt(). In such cases
> pr_fmt() should be undefined and redefined.
> 
> Doing this properly shaves down compilation time quite
> considerably.
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
> ---
>  net/bluetooth/lib.c |    2 ++
>  1 file changed, 2 insertions(+)

Patch has been applie, thanks.

	Gustavo

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] bluetooth: properly use pr_fmt() on lib.c

[Marcel Holtmann]

Hi Gustavo,

> > pr_fmt() is either defined or we redefine it. Typically
> > drivers define it prior to including printk.h but this
> > is done under the assumption that no other subsystem
> > it uses has already defined pr_fmt(). In such cases
> > pr_fmt() should be undefined and redefined.
> > 
> > Doing this properly shaves down compilation time quite
> > considerably.
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
> > ---
> >  net/bluetooth/lib.c |    2 ++
> >  1 file changed, 2 insertions(+)
> 
> Patch has been applie, thanks.

please get into the habit to let them know if it got applied to
bluetooth tree or bluetooth-next tree or both.

Regards

Marcel