Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
@ 2012-08-02 12:42 shea
  2012-08-02 12:45 ` Shea Levy
  0 siblings, 1 reply; 7+ messages in thread
From: shea @ 2012-08-02 12:42 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Gustavo Padovan, Johan Hedberg, linux-bluetooth, linux-kernel,
	Shea Levy

From: Shea Levy <shea@shealevy.com>

---
 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e272214..e4ecd5e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -73,6 +73,9 @@ static struct usb_device_id btusb_table[] = {
 	/* Apple MacBookPro8,2 */
 	{ USB_DEVICE(0x05ac, 0x821a) },
 
+	/* Apple MacBookPro9,2 */
+	{ USB_DEVICE(0x05ac, 0x821d) },
+
 	/* Apple MacMini5,1 */
 	{ USB_DEVICE(0x05ac, 0x8281) },
 
-- 
1.7.11

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
  2012-08-02 12:42 shea
@ 2012-08-02 12:45 ` Shea Levy
  0 siblings, 0 replies; 7+ messages in thread
From: Shea Levy @ 2012-08-02 12:45 UTC (permalink / raw)
  To: shea@shealevy.com
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org

Argh, sorry, forgot the sign-off. Will resend after checkpatch passes. Sorry=
 for the noise.

On Aug 2, 2012, at 8:42 AM, shea@shealevy.com wrote:

> From: Shea Levy <shea@shealevy.com>
>=20
> ---
> drivers/bluetooth/btusb.c | 3 +++
> 1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index e272214..e4ecd5e 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -73,6 +73,9 @@ static struct usb_device_id btusb_table[] =3D {
>    /* Apple MacBookPro8,2 */
>    { USB_DEVICE(0x05ac, 0x821a) },
>=20
> +    /* Apple MacBookPro9,2 */
> +    { USB_DEVICE(0x05ac, 0x821d) },
> +
>    /* Apple MacMini5,1 */
>    { USB_DEVICE(0x05ac, 0x8281) },
>=20
> --=20
> 1.7.11
>=20
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"=
 in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
@ 2012-08-02 12:45 shea
  2012-08-02 13:32 ` David Herrmann
  0 siblings, 1 reply; 7+ messages in thread
From: shea @ 2012-08-02 12:45 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Gustavo Padovan, Johan Hedberg, linux-bluetooth, linux-kernel,
	Shea Levy

From: Shea Levy <shea@shealevy.com>


Signed-off-by: Shea Levy <shea@shealevy.com>
---
 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e272214..e4ecd5e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -73,6 +73,9 @@ static struct usb_device_id btusb_table[] = {
 	/* Apple MacBookPro8,2 */
 	{ USB_DEVICE(0x05ac, 0x821a) },
 
+	/* Apple MacBookPro9,2 */
+	{ USB_DEVICE(0x05ac, 0x821d) },
+
 	/* Apple MacMini5,1 */
 	{ USB_DEVICE(0x05ac, 0x8281) },
 
-- 
1.7.11

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
  2012-08-02 12:45 [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2 shea
@ 2012-08-02 13:32 ` David Herrmann
  2012-08-02 13:39   ` Shea Levy
  0 siblings, 1 reply; 7+ messages in thread
From: David Herrmann @ 2012-08-02 13:32 UTC (permalink / raw)
  To: shea
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg, linux-bluetooth,
	linux-kernel

Hi Shea

On Thu, Aug 2, 2012 at 2:45 PM,  <shea@shealevy.com> wrote:
> From: Shea Levy <shea@shealevy.com>
>
>
> Signed-off-by: Shea Levy <shea@shealevy.com>

Why is this patch missing a commit-message? Please add one. And also
include the output of "usb-devices" or the contents of
/sys/kernel/debug/usb/devices in this commit-message.

Regards
David

> ---
>  drivers/bluetooth/btusb.c | 3 +++
>  1 file changed, 3 insertions(+)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
  2012-08-02 13:32 ` David Herrmann
@ 2012-08-02 13:39   ` Shea Levy
  2012-08-02 13:45     ` David Herrmann
  0 siblings, 1 reply; 7+ messages in thread
From: Shea Levy @ 2012-08-02 13:39 UTC (permalink / raw)
  To: David Herrmann
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org

Hi David,

On Aug 2, 2012, at 9:32 AM, David Herrmann <dh.herrmann@googlemail.com> wrot=
e:

> Hi Shea
>=20
> On Thu, Aug 2, 2012 at 2:45 PM,  <shea@shealevy.com> wrote:
>> From: Shea Levy <shea@shealevy.com>
>>=20
>>=20
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>=20
> Why is this patch missing a commit-message? Please add one.

The commit message was only one line, which git-send-email puts in the subje=
ct.

> And also
> include the output of "usb-devices" or the contents of
> /sys/kernel/debug/usb/devices in this commit-message.
>=20

OK. The whole thing or just the relevant bits? Does it matter if I'm booted i=
nto the patched kernel or not?

Thanks,
Shea=

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
  2012-08-02 13:39   ` Shea Levy
@ 2012-08-02 13:45     ` David Herrmann
  0 siblings, 0 replies; 7+ messages in thread
From: David Herrmann @ 2012-08-02 13:45 UTC (permalink / raw)
  To: Shea Levy
  Cc: Marcel Holtmann, Gustavo Padovan, Johan Hedberg,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org

Hi Shea

On Thu, Aug 2, 2012 at 3:39 PM, Shea Levy <shea@shealevy.com> wrote:
> Hi David,
>
> On Aug 2, 2012, at 9:32 AM, David Herrmann <dh.herrmann@googlemail.com> wrote:
>
>> Hi Shea
>>
>> On Thu, Aug 2, 2012 at 2:45 PM,  <shea@shealevy.com> wrote:
>>> From: Shea Levy <shea@shealevy.com>
>>>
>>>
>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>
>> Why is this patch missing a commit-message? Please add one.
>
> The commit message was only one line, which git-send-email puts in the subject.

I know that. But I prefer non-empty commit-message bodies. Well, maybe
I am the only one ;)

>> And also
>> include the output of "usb-devices" or the contents of
>> /sys/kernel/debug/usb/devices in this commit-message.
>>
>
> OK. The whole thing or just the relevant bits? Does it matter if I'm booted into the patched kernel or not?

Just copy the output of the relevant parts, that is, the one for your
device. It is used by the maintainer to validate that there was no
copy/paste mistake. It doesn't matter if booted with or without the
patch.

Thanks
David

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2
@ 2012-08-02 13:47 shea
  0 siblings, 0 replies; 7+ messages in thread
From: shea @ 2012-08-02 13:47 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Gustavo Padovan, Johan Hedberg, linux-bluetooth, linux-kernel,
	Shea Levy

From: Shea Levy <shea@shealevy.com>

$ usb-devices
<snip>
T:  Bus=04 Lev=04 Prnt=04 Port=02 Cnt=01 Dev#=  9 Spd=12  MxCh= 0
D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=05ac ProdID=821d Rev=00.86
S:  Manufacturer=Apple Inc.
S:  Product=Bluetooth USB Host Controller
C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=btusb
I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
<snip>

Signed-off-by: Shea Levy <shea@shealevy.com>
---
 drivers/bluetooth/btusb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index e272214..e4ecd5e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -73,6 +73,9 @@ static struct usb_device_id btusb_table[] = {
 	/* Apple MacBookPro8,2 */
 	{ USB_DEVICE(0x05ac, 0x821a) },
 
+	/* Apple MacBookPro9,2 */
+	{ USB_DEVICE(0x05ac, 0x821d) },
+
 	/* Apple MacMini5,1 */
 	{ USB_DEVICE(0x05ac, 0x8281) },
 
-- 
1.7.11

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2012-08-02 13:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-02 12:45 [PATCH] Bluetooth: Add support for Apple MacBook Pro 9,2 shea
2012-08-02 13:32 ` David Herrmann
2012-08-02 13:39   ` Shea Levy
2012-08-02 13:45     ` David Herrmann
  -- strict thread matches above, loose matches on Subject: below --
2012-08-02 13:47 shea
2012-08-02 12:42 shea
2012-08-02 12:45 ` Shea Levy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox