* [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb()
@ 2012-08-28 13:12 Wei Yongjun
2012-08-28 17:10 ` Marcel Holtmann
2012-08-28 17:24 ` Gustavo Padovan
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-08-28 13:12 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg; +Cc: yongjun_wei, linux-bluetooth
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Remove pointless conditional before kfree_skb().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/bluetooth/btmrvl_sdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 6a9e971..48ae86f 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -600,8 +600,7 @@ static int btmrvl_sdio_card_to_host(struct btmrvl_private *priv)
exit:
if (ret) {
hdev->stat.err_rx++;
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
}
return ret;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb()
2012-08-28 13:12 [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb() Wei Yongjun
@ 2012-08-28 17:10 ` Marcel Holtmann
2012-08-28 17:24 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2012-08-28 17:10 UTC (permalink / raw)
To: Wei Yongjun; +Cc: gustavo, johan.hedberg, yongjun_wei, linux-bluetooth
Hi Wei,
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb()
2012-08-28 13:12 [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 17:10 ` Marcel Holtmann
@ 2012-08-28 17:24 ` Gustavo Padovan
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo Padovan @ 2012-08-28 17:24 UTC (permalink / raw)
To: Wei Yongjun; +Cc: marcel, johan.hedberg, yongjun_wei, linux-bluetooth
Hi Wei,
* Wei Yongjun <weiyj.lk@gmail.com> [2012-08-28 21:12:48 +0800]:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch has been applied to bluetooth-next. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-28 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 13:12 [PATCH] Bluetooth: btmrvl: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 17:10 ` Marcel Holtmann
2012-08-28 17:24 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox