From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 02/10] gdbus: Remove connection from g_dbus_remove_watch
Date: Mon, 1 Oct 2012 20:53:33 +0300 [thread overview]
Message-ID: <1349114021-19067-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1349114021-19067-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The connection is not really needed since the list of listeners is
global not per connection, besides it is more convenient this way as
only the id is needed.
---
gdbus/gdbus.h | 2 +-
gdbus/watch.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
index 0a8a27c..3bd8986 100644
--- a/gdbus/gdbus.h
+++ b/gdbus/gdbus.h
@@ -217,7 +217,7 @@ guint g_dbus_add_signal_watch(DBusConnection *connection,
const char *interface, const char *member,
GDBusSignalFunction function, void *user_data,
GDBusDestroyFunction destroy);
-gboolean g_dbus_remove_watch(DBusConnection *connection, guint tag);
+gboolean g_dbus_remove_watch(guint id);
void g_dbus_remove_all_watches(DBusConnection *connection);
#ifdef __cplusplus
diff --git a/gdbus/watch.c b/gdbus/watch.c
index 07feb61..00cedae 100644
--- a/gdbus/watch.c
+++ b/gdbus/watch.c
@@ -285,7 +285,7 @@ static void filter_data_free(struct filter_data *data)
g_free(l->data);
g_slist_free(data->callbacks);
- g_dbus_remove_watch(data->connection, data->name_watch);
+ g_dbus_remove_watch(data->name_watch);
g_free(data->name);
g_free(data->owner);
g_free(data->path);
@@ -752,7 +752,7 @@ guint g_dbus_add_signal_watch(DBusConnection *connection,
return cb->id;
}
-gboolean g_dbus_remove_watch(DBusConnection *connection, guint id)
+gboolean g_dbus_remove_watch(guint id)
{
struct filter_data *data;
struct filter_callback *cb;
--
1.7.11.4
next prev parent reply other threads:[~2012-10-01 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 17:53 [PATCH BlueZ 01/10] gdbus: Fix not freeing list node by using g_slist_delete_link Luiz Augusto von Dentz
2012-10-01 17:53 ` Luiz Augusto von Dentz [this message]
2012-10-02 4:23 ` [PATCH BlueZ 02/10] gdbus: Remove connection from g_dbus_remove_watch Lucas De Marchi
2012-10-02 8:05 ` Luiz Augusto von Dentz
2012-10-02 10:49 ` Lucas De Marchi
2012-10-02 13:57 ` Luiz Augusto von Dentz
2012-10-04 8:42 ` Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 03/10] Fix passing D-Bus connection to g_dbus_remove_watch Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 04/10] audio: Fix not freeing gateway agent data on exit Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 05/10] AVRCP: Fix not freeing player session list " Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 06/10] AVRCP: Fix not removing session from player upon disconnect Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 07/10] AVCTP: Simplify channel handling Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 08/10] AVCTP: Allocate memory to hold incoming/outgoing PDUs Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 09/10] AVRCP: Register to AVCTP state changes without depending on player Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 10/10] AVRCP: Don't respond with errors when no player is registered Luiz Augusto von Dentz
2012-10-02 4:10 ` [PATCH BlueZ 01/10] gdbus: Fix not freeing list node by using g_slist_delete_link Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349114021-19067-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox