From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 06/10] AVRCP: Fix not removing session from player upon disconnect
Date: Mon, 1 Oct 2012 20:53:37 +0300 [thread overview]
Message-ID: <1349114021-19067-6-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1349114021-19067-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Invalid read of size 8
at 0x1310E3: avrcp_unregister_player (avrcp.c:1604)
by 0x13EB57: path_free (media.c:1834)
by 0x123208: remove_interface.isra.1 (object.c:558)
by 0x1238DD: g_dbus_unregister_interface (object.c:705)
by 0x124BB8: media_server_remove (manager.c:1077)
by 0x4E91C5C: g_slist_foreach (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x17B349: adapter_remove (adapter.c:2309)
by 0x176F39: manager_cleanup (manager.c:290)
by 0x120E65: main (main.c:555)
Address 0x6685058 is 24 bytes inside a block of size 80 free'd
at 0x4C279AE: free (vg_replace_malloc.c:427)
by 0x4E7C50E: g_free (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x12FC97: state_changed (avrcp.c:1380)
by 0x12D351: avctp_set_state (avctp.c:396)
by 0x12D7B4: session_cb (avctp.c:601)
by 0x4E76824: g_main_context_dispatch (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x4E76B57: ??? (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x4E76F51: g_main_loop_run (in /usr/lib64/libglib-2.0.so.0.3200.4)
by 0x120E51: main (main.c:551)
---
audio/avrcp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/audio/avrcp.c b/audio/avrcp.c
index 49f1550..2e36fb7 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -1328,6 +1328,11 @@ static void state_changed(struct audio_device *dev, avctp_state_t old_state,
avctp_unregister_browsing_pdu_handler(
session->browsing_handler);
+ if (session->player != NULL)
+ session->player->sessions = g_slist_remove(
+ session->player->sessions,
+ session);
+
g_free(session);
break;
case AVCTP_STATE_CONNECTING:
--
1.7.11.4
next prev parent reply other threads:[~2012-10-01 17:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 17:53 [PATCH BlueZ 01/10] gdbus: Fix not freeing list node by using g_slist_delete_link Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 02/10] gdbus: Remove connection from g_dbus_remove_watch Luiz Augusto von Dentz
2012-10-02 4:23 ` Lucas De Marchi
2012-10-02 8:05 ` Luiz Augusto von Dentz
2012-10-02 10:49 ` Lucas De Marchi
2012-10-02 13:57 ` Luiz Augusto von Dentz
2012-10-04 8:42 ` Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 03/10] Fix passing D-Bus connection to g_dbus_remove_watch Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 04/10] audio: Fix not freeing gateway agent data on exit Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 05/10] AVRCP: Fix not freeing player session list " Luiz Augusto von Dentz
2012-10-01 17:53 ` Luiz Augusto von Dentz [this message]
2012-10-01 17:53 ` [PATCH BlueZ 07/10] AVCTP: Simplify channel handling Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 08/10] AVCTP: Allocate memory to hold incoming/outgoing PDUs Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 09/10] AVRCP: Register to AVCTP state changes without depending on player Luiz Augusto von Dentz
2012-10-01 17:53 ` [PATCH BlueZ 10/10] AVRCP: Don't respond with errors when no player is registered Luiz Augusto von Dentz
2012-10-02 4:10 ` [PATCH BlueZ 01/10] gdbus: Fix not freeing list node by using g_slist_delete_link Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349114021-19067-6-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox