Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Jaganath Kanakkassery <jaganath.k@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] shared: Fix build break
Date: Mon, 07 Jan 2013 19:20:07 -0800	[thread overview]
Message-ID: <1357615207.1806.17.camel@aeonflux> (raw)
In-Reply-To: <1357562033-26230-2-git-send-email-jaganath.k@samsung.com>

Hi Jaganath,

> This patch fixes the below build error
> 
> src/shared/mgmt.c: In function ‘mgmt_cancel_index’:
> src/shared/mgmt.c:559:30: error: cast to pointer from integer of
> different size [-Werror=int-to-pointer-cast]
> cc1: all warnings being treated as errors
> make[1]: *** [src/shared/bluetoothd-mgmt.o] Error 1
> make: *** [all] Error 2
> ---
>  src/shared/mgmt.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/shared/mgmt.c b/src/shared/mgmt.c
> index 2297caf..c832a88 100644
> --- a/src/shared/mgmt.c
> +++ b/src/shared/mgmt.c
> @@ -553,10 +553,12 @@ bool mgmt_cancel(struct mgmt *mgmt, unsigned int id)
>  
>  bool mgmt_cancel_index(struct mgmt *mgmt, uint16_t index)
>  {
> +	guint id = index;
> +

I changed this into unsigned int instead when applying the patch.

Regards

Marcel



  reply	other threads:[~2013-01-08  3:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-07 12:33 [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Jaganath Kanakkassery
2013-01-07 12:33 ` [PATCH 2/2] shared: Fix build break Jaganath Kanakkassery
2013-01-08  3:20   ` Marcel Holtmann [this message]
2013-01-07 13:12 ` [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Ludek Finstrle
2013-01-07 13:52   ` Jaganath Kanakkassery
2013-01-07 20:00     ` Luiz Augusto von Dentz
2013-01-08  3:24       ` Marcel Holtmann
2013-01-08  3:22 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357615207.1806.17.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=jaganath.k@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox