From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Jaganath Kanakkassery <jaganath.k@samsung.com>,
Ludek Finstrle <luf@pzkagis.cz>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup()
Date: Mon, 07 Jan 2013 19:24:00 -0800 [thread overview]
Message-ID: <1357615440.1806.21.camel@aeonflux> (raw)
In-Reply-To: <CABBYNZ+0H3t-jwbp_-iUeFw2NOqXuWmwBiw8xjqP5bx6D7gomQ@mail.gmail.com>
Hi Luiz,
<snip>
> > I think
> > return g_hash_table_lookup(mp->settings, property->name) ? TRUE : FALSE;
> > would be better?
>
> Shorter form is != NULL, so lets go with it, still haven't figure out
> why we didn't bring back glib-compat for such functions, when we
> finally upgrade it will take much more time to revert this one by one.
we could bring glib-compat back, but right now I do not want to
introduce more autoconf magic to do so.
I would require the latest GLib version (or at least a bit newer one) if
they wouldn't just start introducing new dependencies all the time.
Regards
Marcel
next prev parent reply other threads:[~2013-01-08 3:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 12:33 [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Jaganath Kanakkassery
2013-01-07 12:33 ` [PATCH 2/2] shared: Fix build break Jaganath Kanakkassery
2013-01-08 3:20 ` Marcel Holtmann
2013-01-07 13:12 ` [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Ludek Finstrle
2013-01-07 13:52 ` Jaganath Kanakkassery
2013-01-07 20:00 ` Luiz Augusto von Dentz
2013-01-08 3:24 ` Marcel Holtmann [this message]
2013-01-08 3:22 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357615440.1806.21.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=jaganath.k@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luf@pzkagis.cz \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox