Linux bluetooth development
 help / color / mirror / Atom feed
From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 1/7] Bluetooth: Initialize hci_conn fields in hci_connect_le
Date: Tue,  1 Oct 2013 20:03:50 -0300	[thread overview]
Message-ID: <1380668636-30654-2-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1380668636-30654-1-git-send-email-andre.guedes@openbossa.org>

This patch moves some hci_conn fields initialization from hci_le_
create_connection() to hci_connect_le(). It makes more sense to
initialize these fields within the function that creates the hci_
conn object.

Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
 net/bluetooth/hci_conn.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index d2380e0..f473605 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -54,11 +54,6 @@ static void hci_le_create_connection(struct hci_conn *conn)
 	struct hci_dev *hdev = conn->hdev;
 	struct hci_cp_le_create_conn cp;
 
-	conn->state = BT_CONNECT;
-	conn->out = true;
-	conn->link_mode |= HCI_LM_MASTER;
-	conn->sec_level = BT_SECURITY_LOW;
-
 	memset(&cp, 0, sizeof(cp));
 	cp.scan_interval = __constant_cpu_to_le16(0x0060);
 	cp.scan_window = __constant_cpu_to_le16(0x0030);
@@ -565,6 +560,11 @@ static struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst,
 			return ERR_PTR(-ENOMEM);
 
 		le->dst_type = bdaddr_to_le(dst_type);
+		le->state = BT_CONNECT;
+		le->out = true;
+		le->link_mode |= HCI_LM_MASTER;
+		le->sec_level = BT_SECURITY_LOW;
+
 		hci_le_create_connection(le);
 	}
 
-- 
1.8.4


  reply	other threads:[~2013-10-01 23:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01 23:03 [PATCH 0/7] LE connection refactoring and fixes Andre Guedes
2013-10-01 23:03 ` Andre Guedes [this message]
2013-10-02  4:57   ` [PATCH 1/7] Bluetooth: Initialize hci_conn fields in hci_connect_le Marcel Holtmann
2013-10-03 14:03     ` Andre Guedes
2013-10-01 23:03 ` [PATCH 2/7] Bluetooth: Use HCI request for LE connection Andre Guedes
2013-10-02  5:04   ` Marcel Holtmann
2013-10-03 14:03     ` Andre Guedes
2013-10-01 23:03 ` [PATCH 3/7] Bluetooth: Remove hci_le_create_connection Andre Guedes
2013-10-02  5:08   ` Marcel Holtmann
2013-10-03 14:03     ` Andre Guedes
2013-10-01 23:03 ` [PATCH 4/7] Bluetooth: Remove hci_cs_le_create_conn event handler Andre Guedes
2013-10-01 23:44   ` Anderson Lizardo
2013-10-02  5:11   ` Marcel Holtmann
2013-10-03 14:04     ` Andre Guedes
2013-10-03 14:13       ` Marcel Holtmann
2013-10-01 23:03 ` [PATCH 5/7] Bluetooth: Refactor hci_connect_le Andre Guedes
2013-10-02  0:05   ` Anderson Lizardo
2013-10-03 14:04     ` Andre Guedes
2013-10-01 23:03 ` [PATCH 6/7] Bluetooth: Refactor LE Connection Complete HCI event handler Andre Guedes
2013-10-02  5:21   ` Marcel Holtmann
2013-10-03 14:06     ` Andre Guedes
2013-10-03 14:15       ` Marcel Holtmann
2013-10-03 18:22         ` Andre Guedes
2013-10-01 23:03 ` [PATCH 7/7] Bluetooth: Locking in hci_le_conn_complete_evt Andre Guedes
2013-10-02  5:23   ` Marcel Holtmann
2013-10-03 14:06     ` Andre Guedes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380668636-30654-2-git-send-email-andre.guedes@openbossa.org \
    --to=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox