From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 2/7] Bluetooth: Use HCI request for LE connection
Date: Tue, 1 Oct 2013 20:03:51 -0300 [thread overview]
Message-ID: <1380668636-30654-3-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1380668636-30654-1-git-send-email-andre.guedes@openbossa.org>
This patch adds a new helper for initiating LE conneciton which uses
the HCI request framework. This patch also changes the hci_connect_le()
so it uses the new helper instead of the old hci_le_create_connection().
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
include/net/bluetooth/hci_core.h | 2 ++
net/bluetooth/hci_conn.c | 7 +++++-
net/bluetooth/hci_core.c | 46 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 54 insertions(+), 1 deletion(-)
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 26cc9f7..6aa172c 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -1216,6 +1216,8 @@ void hci_le_start_enc(struct hci_conn *conn, __le16 ediv, __u8 rand[8],
u8 bdaddr_to_le(u8 bdaddr_type);
+int hci_initiate_le_connection(struct hci_dev *hdev, bdaddr_t *addr, u8 type);
+
#define SCO_AIRMODE_MASK 0x0003
#define SCO_AIRMODE_CVSD 0x0000
#define SCO_AIRMODE_TRANSP 0x0003
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index f473605..24d1a0a 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -545,6 +545,7 @@ static struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst,
u8 dst_type, u8 sec_level, u8 auth_type)
{
struct hci_conn *le;
+ int err;
if (test_bit(HCI_LE_PERIPHERAL, &hdev->flags))
return ERR_PTR(-ENOTSUPP);
@@ -565,7 +566,11 @@ static struct hci_conn *hci_connect_le(struct hci_dev *hdev, bdaddr_t *dst,
le->link_mode |= HCI_LM_MASTER;
le->sec_level = BT_SECURITY_LOW;
- hci_le_create_connection(le);
+ err = hci_initiate_le_connection(hdev, &le->dst, le->dst_type);
+ if (err) {
+ hci_conn_del(le);
+ return ERR_PTR(err);
+ }
}
le->pending_sec_level = sec_level;
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 4549b5c..51c1796 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3631,3 +3631,49 @@ u8 bdaddr_to_le(u8 bdaddr_type)
return ADDR_LE_DEV_RANDOM;
}
}
+
+static void initiate_le_connection_complete(struct hci_dev *hdev, u8 status)
+{
+ struct hci_conn *conn;
+
+ if (status == 0)
+ return;
+
+ BT_ERR("HCI request failed to initiate LE connection: status 0x%2.2x",
+ status);
+
+ conn = hci_conn_hash_lookup_state(hdev, LE_LINK, BT_CONNECT);
+ if (!conn)
+ return;
+
+ mgmt_connect_failed(hdev, &conn->dst, conn->type, conn->dst_type,
+ status);
+
+ hci_proto_connect_cfm(conn, status);
+
+ hci_dev_lock(hdev);
+ hci_conn_del(conn);
+ hci_dev_unlock(hdev);
+}
+
+int hci_initiate_le_connection(struct hci_dev *hdev, bdaddr_t *addr, u8 type)
+{
+ struct hci_cp_le_create_conn cp;
+ struct hci_request req;
+
+ hci_req_init(&req, hdev);
+
+ memset(&cp, 0, sizeof(cp));
+ cp.scan_interval = __constant_cpu_to_le16(0x0060);
+ cp.scan_window = __constant_cpu_to_le16(0x0030);
+ bacpy(&cp.peer_addr, addr);
+ cp.peer_addr_type = type;
+ cp.conn_interval_min = __constant_cpu_to_le16(0x0028);
+ cp.conn_interval_max = __constant_cpu_to_le16(0x0038);
+ cp.supervision_timeout = __constant_cpu_to_le16(0x002a);
+ cp.min_ce_len = __constant_cpu_to_le16(0x0000);
+ cp.max_ce_len = __constant_cpu_to_le16(0x0000);
+ hci_req_add(&req, HCI_OP_LE_CREATE_CONN, sizeof(cp), &cp);
+
+ return hci_req_run(&req, initiate_le_connection_complete);
+}
--
1.8.4
next prev parent reply other threads:[~2013-10-01 23:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 23:03 [PATCH 0/7] LE connection refactoring and fixes Andre Guedes
2013-10-01 23:03 ` [PATCH 1/7] Bluetooth: Initialize hci_conn fields in hci_connect_le Andre Guedes
2013-10-02 4:57 ` Marcel Holtmann
2013-10-03 14:03 ` Andre Guedes
2013-10-01 23:03 ` Andre Guedes [this message]
2013-10-02 5:04 ` [PATCH 2/7] Bluetooth: Use HCI request for LE connection Marcel Holtmann
2013-10-03 14:03 ` Andre Guedes
2013-10-01 23:03 ` [PATCH 3/7] Bluetooth: Remove hci_le_create_connection Andre Guedes
2013-10-02 5:08 ` Marcel Holtmann
2013-10-03 14:03 ` Andre Guedes
2013-10-01 23:03 ` [PATCH 4/7] Bluetooth: Remove hci_cs_le_create_conn event handler Andre Guedes
2013-10-01 23:44 ` Anderson Lizardo
2013-10-02 5:11 ` Marcel Holtmann
2013-10-03 14:04 ` Andre Guedes
2013-10-03 14:13 ` Marcel Holtmann
2013-10-01 23:03 ` [PATCH 5/7] Bluetooth: Refactor hci_connect_le Andre Guedes
2013-10-02 0:05 ` Anderson Lizardo
2013-10-03 14:04 ` Andre Guedes
2013-10-01 23:03 ` [PATCH 6/7] Bluetooth: Refactor LE Connection Complete HCI event handler Andre Guedes
2013-10-02 5:21 ` Marcel Holtmann
2013-10-03 14:06 ` Andre Guedes
2013-10-03 14:15 ` Marcel Holtmann
2013-10-03 18:22 ` Andre Guedes
2013-10-01 23:03 ` [PATCH 7/7] Bluetooth: Locking in hci_le_conn_complete_evt Andre Guedes
2013-10-02 5:23 ` Marcel Holtmann
2013-10-03 14:06 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380668636-30654-3-git-send-email-andre.guedes@openbossa.org \
--to=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox