* [PATCH] Bluetooth: Add function name to debug prints
@ 2013-10-22 7:09 Jukka Rissanen
2013-10-22 7:29 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Jukka Rissanen @ 2013-10-22 7:09 UTC (permalink / raw)
To: linux-bluetooth
---
Hi,
the debug prints are quite useless without the function name.
Without this patch one sees lot of "hci0" lines which is not
very helpful.
Cheers,
Jukka
include/net/bluetooth/bluetooth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index bf2ddff..0b1eacd 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -122,7 +122,7 @@ int bt_err(const char *fmt, ...);
#define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
#define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
-#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
+#define BT_DBG(fmt, ...) pr_debug("%s():" fmt "\n", __FUNCTION__, ##__VA_ARGS__)
/* Connection and socket states */
enum {
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Bluetooth: Add function name to debug prints
2013-10-22 7:09 [PATCH] Bluetooth: Add function name to debug prints Jukka Rissanen
@ 2013-10-22 7:29 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2013-10-22 7:29 UTC (permalink / raw)
To: Jukka Rissanen; +Cc: linux-bluetooth
Hi Jukka,
On Tue, Oct 22, 2013, Jukka Rissanen wrote:
> the debug prints are quite useless without the function name.
> Without this patch one sees lot of "hci0" lines which is not
> very helpful.
>
> Cheers,
> Jukka
>
> include/net/bluetooth/bluetooth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index bf2ddff..0b1eacd 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -122,7 +122,7 @@ int bt_err(const char *fmt, ...);
>
> #define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
> #define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
> -#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
> +#define BT_DBG(fmt, ...) pr_debug("%s():" fmt "\n", __FUNCTION__, ##__VA_ARGS__)
This shouldn't be necessary since you can ask the function name to be
printed using standard dynamic debug control syntax, e.g:
echo "file hci_event.c +pf" > /sys/kernel/debug/dynamic_debug/control
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-22 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22 7:09 [PATCH] Bluetooth: Add function name to debug prints Jukka Rissanen
2013-10-22 7:29 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox