Linux bluetooth development
 help / color / mirror / Atom feed
From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv4 0/8] Improve logging for Android
Date: Wed, 30 Oct 2013 14:16:38 +0200	[thread overview]
Message-ID: <1383135406-23658-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1383051459-29495-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Logging on Android is really important since we do not have specification
how and in which order hal functions are called, sometimes the only way is
to examine logs or read Java Bluetooth code.

Changes:
	* v4: Rebased against latest upstream
	* v3: Merged first two patches.
	* v2: Added thread-safe helpers for printing properties, bdaddr, etc
	after comments that simple printing is not thread-safe. The idea is to
	use TLS (thread local storage) like bionic is doing for strerror for
	example. More info can be found on manpage for pthread_key_create.

This patch series uses debug functions defined already for haltest and
allows to print very helpful logs on Android target like shown below:

...
hal-bluetooth.c:set_adapter_property() prop: type=BT_PROPERTY_ADAPTER_SCAN_MODE len=4 val=BT_SCAN_MODE_NONE
...

Andrei Emeltchenko (8):
  android/haltest: Export print property
  android/haltest: Use pointer as parameter for debug
  android/hal: Print full property in debug
  android/hal: Add extra logs
  android/hal: Print adapter state
  android/hal: Print adapter property in callback
  android: Add thread-safe helpers
  android: Use thread-safe helpers

 android/client/if-bt.c    |  112 +------------------------------------------
 android/client/textconv.c |  115 +++++++++++++++++++++++++++++++++++++++++++++
 android/client/textconv.h |    3 ++
 android/hal-bluetooth.c   |   28 ++++++-----
 android/pthread-local.h   |   58 +++++++++++++++++++++++
 5 files changed, 194 insertions(+), 122 deletions(-)
 create mode 100644 android/pthread-local.h

-- 
1.7.10.4


  parent reply	other threads:[~2013-10-30 12:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 12:57 [PATCHv3 0/9] Improve logging for Android Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 1/9] android/haltest: Export print property Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 2/9] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 3/9] android/hal: Print full property in debug Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 4/9] android/hal: Add extra logs Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 5/9] android/hal: Print adapter state Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 6/9] android/hal: Print adapter property in callback Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 7/9] android: Add thread-safe helpers Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 8/9] android: Use " Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 9/9] android: Fix build errors Andrei Emeltchenko
2013-10-30 12:16 ` Andrei Emeltchenko [this message]
2013-10-30 12:16   ` [PATCHv4 1/8] android/haltest: Export print property Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 2/8] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 3/8] android/hal: Print full property in debug Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 4/8] android/hal: Add extra logs Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 5/8] android/hal: Print adapter state Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 6/8] android/hal: Print adapter property in callback Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 7/8] android: Add thread-safe helpers Andrei Emeltchenko
2013-10-30 12:16   ` [PATCHv4 8/8] android: Use " Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 0/7] Improve logging for Android Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 1/7] android/haltest: Export print property Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 2/7] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 3/7] android/haltest: Fix print device name Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 4/7] android/hal: Add extra logs to HAL Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 5/7] android: Add thread-safe helpers Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 6/7] android: Use " Andrei Emeltchenko
2013-11-01 15:19   ` [PATCHv5 7/7] android/daemon: Add logs to trace failed cmd Andrei Emeltchenko
2013-11-04  7:34   ` [PATCHv5 0/7] Improve logging for Android Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383135406-23658-1-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox