From: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCHv5 4/7] android/hal: Add extra logs to HAL
Date: Fri, 1 Nov 2013 17:19:16 +0200 [thread overview]
Message-ID: <1383319159-13060-5-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1383319159-13060-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Use exported functions from hal test tool to print properties.
---
android/hal-bluetooth.c | 34 ++++++++++++++++++++++------------
1 file changed, 22 insertions(+), 12 deletions(-)
diff --git a/android/hal-bluetooth.c b/android/hal-bluetooth.c
index 5fb8846..7334d24 100644
--- a/android/hal-bluetooth.c
+++ b/android/hal-bluetooth.c
@@ -40,6 +40,8 @@ static void handle_adapter_state_changed(void *buf)
{
struct hal_ev_adapter_state_changed *ev = buf;
+ DBG("state: %s", bt_state_t2str(ev->state));
+
if (bt_hal_cbacks->adapter_state_changed_cb)
bt_hal_cbacks->adapter_state_changed_cb(ev->state);
}
@@ -74,6 +76,8 @@ static void adapter_props_to_hal(bt_property_t *send_props,
send_props[i].val = hal_prop->val;
break;
}
+
+ DBG("prop[%d]: %s", i, btproperty2str(&send_props[i]));
}
}
@@ -123,6 +127,8 @@ static void device_props_to_hal(bt_property_t *send_props,
p += sizeof(*hal_prop) + hal_prop->len;
hal_prop = p;
+
+ DBG("prop[%d]: %s", i, btproperty2str(&send_props[i]));
}
}
@@ -280,6 +286,8 @@ void bt_notify_adapter(uint16_t opcode, void *buf, uint16_t len)
if (!interface_ready())
return;
+ DBG("opcode 0x%x", opcode);
+
switch (opcode) {
case HAL_EV_ADAPTER_STATE_CHANGED:
handle_adapter_state_changed(buf);
@@ -406,7 +414,7 @@ static int get_adapter_property(bt_property_type_t type)
{
struct hal_cmd_get_adapter_prop cmd;
- DBG("prop: %s", bt_property_type_t2str(type));
+ DBG("prop: %s (%d)", bt_property_type_t2str(type), type);
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -438,7 +446,7 @@ static int set_adapter_property(const bt_property_t *property)
char buf[sizeof(struct hal_cmd_set_adapter_prop) + property->len];
struct hal_cmd_set_adapter_prop *cmd = (void *) buf;
- DBG("prop: %s", bt_property_type_t2str(property->type));
+ DBG("prop: %s", btproperty2str(property));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -463,7 +471,7 @@ static int set_adapter_property(const bt_property_t *property)
static int get_remote_device_properties(bt_bdaddr_t *remote_addr)
{
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(remote_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -474,7 +482,8 @@ static int get_remote_device_properties(bt_bdaddr_t *remote_addr)
static int get_remote_device_property(bt_bdaddr_t *remote_addr,
bt_property_type_t type)
{
- DBG("");
+ DBG("bdaddr: %s prop: %s", bdaddr2str(remote_addr),
+ bt_property_type_t2str(type));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -485,7 +494,8 @@ static int get_remote_device_property(bt_bdaddr_t *remote_addr,
static int set_remote_device_property(bt_bdaddr_t *remote_addr,
const bt_property_t *property)
{
- DBG("");
+ DBG("bdaddr: %s prop: %s", bdaddr2str(remote_addr),
+ btproperty2str(property));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -495,7 +505,7 @@ static int set_remote_device_property(bt_bdaddr_t *remote_addr,
static int get_remote_service_record(bt_bdaddr_t *remote_addr, bt_uuid_t *uuid)
{
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(remote_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -505,7 +515,7 @@ static int get_remote_service_record(bt_bdaddr_t *remote_addr, bt_uuid_t *uuid)
static int get_remote_services(bt_bdaddr_t *remote_addr)
{
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(remote_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -541,7 +551,7 @@ static int create_bond(const bt_bdaddr_t *bd_addr)
{
struct hal_cmd_create_bond cmd;
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(bd_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -556,7 +566,7 @@ static int cancel_bond(const bt_bdaddr_t *bd_addr)
{
struct hal_cmd_cancel_bond cmd;
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(bd_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -571,7 +581,7 @@ static int remove_bond(const bt_bdaddr_t *bd_addr)
{
struct hal_cmd_remove_bond cmd;
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(bd_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -587,7 +597,7 @@ static int pin_reply(const bt_bdaddr_t *bd_addr, uint8_t accept,
{
struct hal_cmd_pin_reply cmd;
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(bd_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
@@ -606,7 +616,7 @@ static int ssp_reply(const bt_bdaddr_t *bd_addr, bt_ssp_variant_t variant,
{
struct hal_cmd_ssp_reply cmd;
- DBG("");
+ DBG("bdaddr: %s", bdaddr2str(bd_addr));
if (!interface_ready())
return BT_STATUS_NOT_READY;
--
1.7.10.4
next prev parent reply other threads:[~2013-11-01 15:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 12:57 [PATCHv3 0/9] Improve logging for Android Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 1/9] android/haltest: Export print property Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 2/9] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 3/9] android/hal: Print full property in debug Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 4/9] android/hal: Add extra logs Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 5/9] android/hal: Print adapter state Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 6/9] android/hal: Print adapter property in callback Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 7/9] android: Add thread-safe helpers Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 8/9] android: Use " Andrei Emeltchenko
2013-10-29 12:57 ` [PATCHv3 9/9] android: Fix build errors Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 0/8] Improve logging for Android Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 1/8] android/haltest: Export print property Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 2/8] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 3/8] android/hal: Print full property in debug Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 4/8] android/hal: Add extra logs Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 5/8] android/hal: Print adapter state Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 6/8] android/hal: Print adapter property in callback Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 7/8] android: Add thread-safe helpers Andrei Emeltchenko
2013-10-30 12:16 ` [PATCHv4 8/8] android: Use " Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 0/7] Improve logging for Android Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 1/7] android/haltest: Export print property Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 2/7] android/haltest: Use pointer as parameter for debug Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 3/7] android/haltest: Fix print device name Andrei Emeltchenko
2013-11-01 15:19 ` Andrei Emeltchenko [this message]
2013-11-01 15:19 ` [PATCHv5 5/7] android: Add thread-safe helpers Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 6/7] android: Use " Andrei Emeltchenko
2013-11-01 15:19 ` [PATCHv5 7/7] android/daemon: Add logs to trace failed cmd Andrei Emeltchenko
2013-11-04 7:34 ` [PATCHv5 0/7] Improve logging for Android Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383319159-13060-5-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox