From: Bastien Nocera <hadess@hadess.net>
To: Vinicius Costa Gomes <vcgomes@gmail.com>
Cc: Matthew Monaco <dgbaley27@0x01b.net>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools/hci2hid: properly format device path
Date: Mon, 04 Nov 2013 17:23:41 +0100 [thread overview]
Message-ID: <1383582221.3373.15.camel@nuvo> (raw)
In-Reply-To: <20131104161805.GA32089@molly.amr.corp.intel.com>
On Mon, 2013-11-04 at 14:18 -0200, Vinicius Costa Gomes wrote:
> Hi Matthew,
>
> On 18:46 Sun 03 Nov, Matthew Monaco wrote:
> > From: Matthew Monaco <matthew.monaco@0x01b.net>
> >
> > ---
> > Hello! I hope this is the correct place to send a bugfix for bluez.
> > tools/hid2hci.c | 15 +++++++++------
> > 1 file changed, 9 insertions(+), 6 deletions(-)
>
> The patch itself looks good.
>
> What I think is missing is a better description of the problem it solves, I
> would suggest including in the commit message the values of 'path' for before
> and after the patch, for a situation that the current implementation doesn't
> work.
>
> Changing the subject line to something like: "tools: Fix wrong paths for
> adapters" would make it easier to tell that this patch is indeed a bug fix.
Isn't this the same patch Giovanni sent a couple of weeks ago?
http://thread.gmane.org/gmane.linux.bluez.kernel/38329
Cheers
next prev parent reply other threads:[~2013-11-04 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 1:46 [PATCH] tools/hci2hid: properly format device path Matthew Monaco
2013-11-04 16:18 ` Vinicius Costa Gomes
2013-11-04 16:23 ` Bastien Nocera [this message]
2013-11-04 16:42 ` Vinicius Costa Gomes
2013-11-04 16:52 ` Matthew Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383582221.3373.15.camel@nuvo \
--to=hadess@hadess.net \
--cc=dgbaley27@0x01b.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vcgomes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox