Re: [PATCH] tools/hci2hid: properly format device path

[Vinicius Costa Gomes <vcgomes@gmail.com>]

Hi Bastien,

On 17:23 Mon 04 Nov, Bastien Nocera wrote:
> On Mon, 2013-11-04 at 14:18 -0200, Vinicius Costa Gomes wrote:
> > Hi Matthew,
> > 
> > On 18:46 Sun 03 Nov, Matthew Monaco wrote:
> > > From: Matthew Monaco <matthew.monaco@0x01b.net>
> > > 
> > > ---
> > > Hello! I hope this is the correct place to send a bugfix for bluez.
> > >  tools/hid2hci.c | 15 +++++++++------
> > >  1 file changed, 9 insertions(+), 6 deletions(-)
> > 
> > The patch itself looks good.
> > 
> > What I think is missing is a better description of the problem it solves, I
> > would suggest including in the commit message the values of 'path' for before
> > and after the patch, for a situation that the current implementation doesn't
> > work.
> > 
> > Changing the subject line to something like: "tools: Fix wrong paths for
> > adapters" would make it easier to tell that this patch is indeed a bug fix.
> 
> Isn't this the same patch Giovanni sent a couple of weeks ago?
> 
> http://thread.gmane.org/gmane.linux.bluez.kernel/38329

Yeah, same fix. Thanks for noticing.

> 
> Cheers
> 


Cheers,
-- 
Vinicius