From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 16/17] Bluetooth: Create hci_req_add_le_passive_scan helper
Date: Tue, 25 Feb 2014 18:01:43 -0300 [thread overview]
Message-ID: <1393362104-12175-17-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1393362104-12175-1-git-send-email-andre.guedes@openbossa.org>
This patches creates the hci_req_add_le_passive_scan helper so it can
be re-used in the next patch.
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
net/bluetooth/hci_core.c | 54 +++++++++++++++++++++++++++---------------------
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index fb4c961..e776624 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -5095,6 +5095,35 @@ void hci_req_add_le_scan_disable(struct hci_request *req)
hci_req_add(req, HCI_OP_LE_SET_SCAN_ENABLE, sizeof(cp), &cp);
}
+static void hci_req_add_le_passive_scan(struct hci_request *req,
+ struct hci_dev *hdev)
+{
+ struct hci_cp_le_set_scan_param param_cp;
+ struct hci_cp_le_set_scan_enable enable_cp;
+ u8 own_addr_type;
+
+ /* Use private address since remote doesn't need to identify us.
+ * Strictly speaking, this is not required since no SCAN_REQ is
+ * sent in passive scanning.
+ */
+ if (hci_update_random_address(req, true, &own_addr_type))
+ return;
+
+ memset(¶m_cp, 0, sizeof(param_cp));
+ param_cp.type = LE_SCAN_PASSIVE;
+ param_cp.interval = cpu_to_le16(hdev->le_scan_interval);
+ param_cp.window = cpu_to_le16(hdev->le_scan_window);
+ param_cp.own_address_type = own_addr_type;
+ hci_req_add(req, HCI_OP_LE_SET_SCAN_PARAM, sizeof(param_cp),
+ ¶m_cp);
+
+ memset(&enable_cp, 0, sizeof(enable_cp));
+ enable_cp.enable = LE_SCAN_ENABLE;
+ enable_cp.filter_dup = LE_SCAN_FILTER_DUP_DISABLE;
+ hci_req_add(req, HCI_OP_LE_SET_SCAN_ENABLE, sizeof(enable_cp),
+ &enable_cp);
+}
+
static void update_background_scan_complete(struct hci_dev *hdev, u8 status)
{
if (status)
@@ -5110,8 +5139,6 @@ static void update_background_scan_complete(struct hci_dev *hdev, u8 status)
*/
void hci_update_background_scan(struct hci_dev *hdev)
{
- struct hci_cp_le_set_scan_param param_cp;
- struct hci_cp_le_set_scan_enable enable_cp;
struct hci_request req;
struct hci_conn *conn;
int err;
@@ -5131,8 +5158,6 @@ void hci_update_background_scan(struct hci_dev *hdev)
BT_DBG("%s stopping background scanning", hdev->name);
} else {
- u8 own_addr_type;
-
/* If there is at least one pending LE connection, we should
* keep the background scan running.
*/
@@ -5149,26 +5174,7 @@ void hci_update_background_scan(struct hci_dev *hdev)
if (conn)
return;
- /* Use private address since remote doesn't need to identify us.
- * Strictly speaking, this is not required since no SCAN_REQ is
- * sent in passive scanning.
- */
- if (hci_update_random_address(&req, true, &own_addr_type))
- return;
-
- memset(¶m_cp, 0, sizeof(param_cp));
- param_cp.type = LE_SCAN_PASSIVE;
- param_cp.interval = cpu_to_le16(hdev->le_scan_interval);
- param_cp.window = cpu_to_le16(hdev->le_scan_window);
- param_cp.own_address_type = own_addr_type;
- hci_req_add(&req, HCI_OP_LE_SET_SCAN_PARAM, sizeof(param_cp),
- ¶m_cp);
-
- memset(&enable_cp, 0, sizeof(enable_cp));
- enable_cp.enable = LE_SCAN_ENABLE;
- enable_cp.filter_dup = LE_SCAN_FILTER_DUP_DISABLE;
- hci_req_add(&req, HCI_OP_LE_SET_SCAN_ENABLE, sizeof(enable_cp),
- &enable_cp);
+ hci_req_add_le_passive_scan(&req, hdev);
BT_DBG("%s starting background scanning", hdev->name);
}
--
1.8.5.4
next prev parent reply other threads:[~2014-02-25 21:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 21:01 [PATCH 00/17] LE auto connection Andre Guedes
2014-02-25 21:01 ` [PATCH 01/17] Bluetooth: Create hci_req_add_le_scan_disable helper Andre Guedes
2014-02-25 21:01 ` [PATCH 02/17] Bluetooth: Declare le_conn_failed in hci_core.h Andre Guedes
2014-02-25 21:01 ` [PATCH 03/17] Bluetooth: Stop scanning on LE connection Andre Guedes
2014-02-26 6:23 ` Marcel Holtmann
2014-02-26 19:34 ` Andre Guedes
2014-02-26 19:50 ` Marcel Holtmann
2014-02-26 20:26 ` Johan Hedberg
2014-02-25 21:01 ` [PATCH 04/17] Bluetooth: Remove unused function Andre Guedes
2014-02-25 21:01 ` [PATCH 05/17] Bluetooth: Refactor HCI connection code Andre Guedes
2014-02-25 21:01 ` [PATCH 06/17] Bluetooth: Move address type conversion to outside hci_connect_le Andre Guedes
2014-02-25 21:01 ` [PATCH 07/17] Bluetooth: Introduce hdev->pend_le_conn list Andre Guedes
2014-02-25 21:01 ` [PATCH 08/17] Bluetooth: Introduce LE auto connection infrastructure Andre Guedes
2014-02-26 6:31 ` Marcel Holtmann
2014-02-26 19:34 ` Andre Guedes
2014-02-25 21:01 ` [PATCH 09/17] Bluetooth: Introduce LE auto connect options Andre Guedes
2014-02-25 21:01 ` [PATCH 10/17] Bluetooth: Connection parameters and auto connection Andre Guedes
2014-02-26 6:33 ` Marcel Holtmann
2014-02-26 19:34 ` Andre Guedes
2014-02-26 19:52 ` Marcel Holtmann
2014-02-25 21:01 ` [PATCH 11/17] Bluetooth: Temporarily stop background scanning on discovery Andre Guedes
2014-02-25 21:01 ` [PATCH 12/17] Bluetooth: Auto connection and power on Andre Guedes
2014-02-25 21:01 ` [PATCH 13/17] Bluetooth: Connection parameters and resolvable address Andre Guedes
2014-02-26 6:37 ` Marcel Holtmann
2014-02-26 19:34 ` Andre Guedes
2014-02-25 21:01 ` [PATCH 14/17] Bluetooth: Support resolvable private addresses Andre Guedes
2014-02-25 21:01 ` [PATCH 15/17] Bluetooth: Add le_auto_conn file on debugfs Andre Guedes
2014-02-26 6:41 ` Marcel Holtmann
2014-02-26 19:35 ` Andre Guedes
2014-02-25 21:01 ` Andre Guedes [this message]
2014-02-26 6:44 ` [PATCH 16/17] Bluetooth: Create hci_req_add_le_passive_scan helper Marcel Holtmann
2014-02-26 19:35 ` Andre Guedes
2014-02-25 21:01 ` [PATCH 17/17] Bluetooth: Update background scan parameters Andre Guedes
2014-02-26 6:47 ` Marcel Holtmann
2014-02-26 19:35 ` Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393362104-12175-17-git-send-email-andre.guedes@openbossa.org \
--to=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox