Linux bluetooth development
 help / color / mirror / Atom feed
From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 17/17] Bluetooth: Update background scan parameters
Date: Tue, 25 Feb 2014 18:01:44 -0300	[thread overview]
Message-ID: <1393362104-12175-18-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1393362104-12175-1-git-send-email-andre.guedes@openbossa.org>

If new scanning parameters are set while background scan is running,
we should restart background scanning so these parameters are updated.

Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
 include/net/bluetooth/hci_core.h |  1 +
 net/bluetooth/hci_core.c         | 26 ++++++++++++++++++++++++++
 net/bluetooth/mgmt.c             |  7 +++++++
 3 files changed, 34 insertions(+)

diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index e0e0eab..8f0ddc8 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -814,6 +814,7 @@ void hci_pend_le_conn_del(struct hci_dev *hdev, bdaddr_t *addr, u8 addr_type);
 void hci_pend_le_conns_clear(struct hci_dev *hdev);
 
 void hci_update_background_scan(struct hci_dev *hdev);
+void hci_restart_background_scan(struct hci_dev *hdev);
 
 void hci_uuids_clear(struct hci_dev *hdev);
 
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index e776624..f5c0e97 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -5183,3 +5183,29 @@ void hci_update_background_scan(struct hci_dev *hdev)
 	if (err)
 		BT_ERR("Failed to run HCI request: err %d", err);
 }
+
+static void restart_background_scan_complete(struct hci_dev *hdev, u8 status)
+{
+	if (status)
+		BT_DBG("HCI request failed to restart background scan: "
+		       "status 0x%2.2x", status);
+}
+
+void hci_restart_background_scan(struct hci_dev *hdev)
+{
+	struct hci_request req;
+	int err;
+
+	hci_req_init(&req, hdev);
+
+	hci_req_add_le_scan_disable(&req);
+	hci_req_add_le_passive_scan(&req, hdev);
+
+	err = hci_req_run(&req, restart_background_scan_complete);
+	if (err) {
+		BT_ERR("Failed to run HCI request: err %d", err);
+		return;
+	}
+
+	BT_DBG("%s re-starting background scanning", hdev->name);
+}
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 2e6564e..08d52f2 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -3924,6 +3924,13 @@ static int set_scan_params(struct sock *sk, struct hci_dev *hdev,
 
 	err = cmd_complete(sk, hdev->id, MGMT_OP_SET_SCAN_PARAMS, 0, NULL, 0);
 
+	/* If background scan is running, restart it so new parameters are
+	 * loaded.
+	 */
+	if (test_bit(HCI_LE_SCAN, &hdev->dev_flags) &&
+	    hdev->discovery.state == DISCOVERY_STOPPED)
+		hci_restart_background_scan(hdev);
+
 	hci_dev_unlock(hdev);
 
 	return err;
-- 
1.8.5.4


  parent reply	other threads:[~2014-02-25 21:01 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 21:01 [PATCH 00/17] LE auto connection Andre Guedes
2014-02-25 21:01 ` [PATCH 01/17] Bluetooth: Create hci_req_add_le_scan_disable helper Andre Guedes
2014-02-25 21:01 ` [PATCH 02/17] Bluetooth: Declare le_conn_failed in hci_core.h Andre Guedes
2014-02-25 21:01 ` [PATCH 03/17] Bluetooth: Stop scanning on LE connection Andre Guedes
2014-02-26  6:23   ` Marcel Holtmann
2014-02-26 19:34     ` Andre Guedes
2014-02-26 19:50       ` Marcel Holtmann
2014-02-26 20:26         ` Johan Hedberg
2014-02-25 21:01 ` [PATCH 04/17] Bluetooth: Remove unused function Andre Guedes
2014-02-25 21:01 ` [PATCH 05/17] Bluetooth: Refactor HCI connection code Andre Guedes
2014-02-25 21:01 ` [PATCH 06/17] Bluetooth: Move address type conversion to outside hci_connect_le Andre Guedes
2014-02-25 21:01 ` [PATCH 07/17] Bluetooth: Introduce hdev->pend_le_conn list Andre Guedes
2014-02-25 21:01 ` [PATCH 08/17] Bluetooth: Introduce LE auto connection infrastructure Andre Guedes
2014-02-26  6:31   ` Marcel Holtmann
2014-02-26 19:34     ` Andre Guedes
2014-02-25 21:01 ` [PATCH 09/17] Bluetooth: Introduce LE auto connect options Andre Guedes
2014-02-25 21:01 ` [PATCH 10/17] Bluetooth: Connection parameters and auto connection Andre Guedes
2014-02-26  6:33   ` Marcel Holtmann
2014-02-26 19:34     ` Andre Guedes
2014-02-26 19:52       ` Marcel Holtmann
2014-02-25 21:01 ` [PATCH 11/17] Bluetooth: Temporarily stop background scanning on discovery Andre Guedes
2014-02-25 21:01 ` [PATCH 12/17] Bluetooth: Auto connection and power on Andre Guedes
2014-02-25 21:01 ` [PATCH 13/17] Bluetooth: Connection parameters and resolvable address Andre Guedes
2014-02-26  6:37   ` Marcel Holtmann
2014-02-26 19:34     ` Andre Guedes
2014-02-25 21:01 ` [PATCH 14/17] Bluetooth: Support resolvable private addresses Andre Guedes
2014-02-25 21:01 ` [PATCH 15/17] Bluetooth: Add le_auto_conn file on debugfs Andre Guedes
2014-02-26  6:41   ` Marcel Holtmann
2014-02-26 19:35     ` Andre Guedes
2014-02-25 21:01 ` [PATCH 16/17] Bluetooth: Create hci_req_add_le_passive_scan helper Andre Guedes
2014-02-26  6:44   ` Marcel Holtmann
2014-02-26 19:35     ` Andre Guedes
2014-02-25 21:01 ` Andre Guedes [this message]
2014-02-26  6:47   ` [PATCH 17/17] Bluetooth: Update background scan parameters Marcel Holtmann
2014-02-26 19:35     ` Andre Guedes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393362104-12175-18-git-send-email-andre.guedes@openbossa.org \
    --to=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox