Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH v2] doc: Add extra mode for a reduced LE privacy mode
@ 2014-06-20 21:52 Marcel Holtmann
  2014-06-21 15:14 ` Lukasz Rymanowski
  0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2014-06-20 21:52 UTC (permalink / raw)
  To: linux-bluetooth

---
 doc/mgmt-api.txt | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index e15a78f3e4b7..dfcf719dc757 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -1646,8 +1646,25 @@ Set Privacy Command
 	This command is used to enable Low Energy Privacy feature using
 	resolvable private addresses.
 
-	The value 0x00 disables privacy mode, the value 0x01 enables
-	privacy mode.
+	The value 0x00 disables privacy mode, the values 0x01 and 0x02
+	enable privacy mode.
+
+	With value 0x01 the kernel will always use the privacy mode. This
+	means resolvable private address is used when the controller is
+	discoverable and also when pairing is initiated.
+
+	With value 0x02 the kernel will use privacy mode with resolvable
+	private address. In case the conroller is pairable and discoverable
+	the identity address is used. Also when pairing is initiated, the
+	connection will be established with the identity address.
+
+	Exposing the identity address when pairable and discoverable or
+	during initated pairing can be a privacy issue. For dual-mode
+	controllers this can be neglected since its public address will
+	be exposed over BR/EDR anyway. The benefit of exposing the
+	identity address for pairing purposes is that it makes matching
+	up devices with dual-mode topology during device discovery now
+	possible.
 
 	When the controller has a public address (mandatory for dual-mode
 	controllers) it is used as identity address. In case the controller
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] doc: Add extra mode for a reduced LE privacy mode
  2014-06-20 21:52 [PATCH v2] doc: Add extra mode for a reduced LE privacy mode Marcel Holtmann
@ 2014-06-21 15:14 ` Lukasz Rymanowski
  2014-06-22 16:36   ` Marcel Holtmann
  0 siblings, 1 reply; 3+ messages in thread
From: Lukasz Rymanowski @ 2014-06-21 15:14 UTC (permalink / raw)
  To: Marcel Holtmann; +Cc: linux-bluetooth@vger.kernel.org

Hi Marcel,

On Fri, Jun 20, 2014 at 11:52 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> ---
>  doc/mgmt-api.txt | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index e15a78f3e4b7..dfcf719dc757 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -1646,8 +1646,25 @@ Set Privacy Command
>         This command is used to enable Low Energy Privacy feature using
>         resolvable private addresses.
>
> -       The value 0x00 disables privacy mode, the value 0x01 enables
> -       privacy mode.
> +       The value 0x00 disables privacy mode, the values 0x01 and 0x02
> +       enable privacy mode.
> +
> +       With value 0x01 the kernel will always use the privacy mode. This
> +       means resolvable private address is used when the controller is
> +       discoverable and also when pairing is initiated.
> +
> +       With value 0x02 the kernel will use privacy mode with resolvable
> +       private address. In case the conroller is pairable and discoverable
> +       the identity address is used. Also when pairing is initiated, the
> +       connection will be established with the identity address.
> +
So once device is not discoverable, RPA will be used in advertising, right?

> +       Exposing the identity address when pairable and discoverable or
> +       during initated pairing can be a privacy issue. For dual-mode
> +       controllers this can be neglected since its public address will
> +       be exposed over BR/EDR anyway.

Since privacy mode 0x02 for LE controllers seems to have a little or
even no sense, maybe it should be not allowed ?


The benefit of exposing the
> +       identity address for pairing purposes is that it makes matching
> +       up devices with dual-mode topology during device discovery now
> +       possible.
>
>         When the controller has a public address (mandatory for dual-mode
>         controllers) it is used as identity address. In case the controller
> --
> 1.9.3
>

BR
Lukasz

> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] doc: Add extra mode for a reduced LE privacy mode
  2014-06-21 15:14 ` Lukasz Rymanowski
@ 2014-06-22 16:36   ` Marcel Holtmann
  0 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2014-06-22 16:36 UTC (permalink / raw)
  To: Lukasz Rymanowski; +Cc: linux-bluetooth@vger.kernel.org

Hi Lukasz,

>> doc/mgmt-api.txt | 21 +++++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)
>> 
>> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
>> index e15a78f3e4b7..dfcf719dc757 100644
>> --- a/doc/mgmt-api.txt
>> +++ b/doc/mgmt-api.txt
>> @@ -1646,8 +1646,25 @@ Set Privacy Command
>>        This command is used to enable Low Energy Privacy feature using
>>        resolvable private addresses.
>> 
>> -       The value 0x00 disables privacy mode, the value 0x01 enables
>> -       privacy mode.
>> +       The value 0x00 disables privacy mode, the values 0x01 and 0x02
>> +       enable privacy mode.
>> +
>> +       With value 0x01 the kernel will always use the privacy mode. This
>> +       means resolvable private address is used when the controller is
>> +       discoverable and also when pairing is initiated.
>> +
>> +       With value 0x02 the kernel will use privacy mode with resolvable
>> +       private address. In case the conroller is pairable and discoverable
>> +       the identity address is used. Also when pairing is initiated, the
>> +       connection will be established with the identity address.
>> +
> So once device is not discoverable, RPA will be used in advertising, right?

Yes. Non-discoverable devices will always advertise with RPA.

>> +       Exposing the identity address when pairable and discoverable or
>> +       during initated pairing can be a privacy issue. For dual-mode
>> +       controllers this can be neglected since its public address will
>> +       be exposed over BR/EDR anyway.
> 
> Since privacy mode 0x02 for LE controllers seems to have a little or
> even no sense, maybe it should be not allowed ?

We could do that, but I do not want to limit this. I consider this a policy decision the daemon can make by itself.

If you for example have a LE only mode controller and want to use a static address as identity address and you are fine with exposing it during pairing, so be it.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-22 16:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 21:52 [PATCH v2] doc: Add extra mode for a reduced LE privacy mode Marcel Holtmann
2014-06-21 15:14 ` Lukasz Rymanowski
2014-06-22 16:36   ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox