* [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx
@ 2014-06-23 13:49 Loic Poulain
2014-06-23 14:04 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Loic Poulain @ 2014-06-23 13:49 UTC (permalink / raw)
To: marcel, gustavo, johan.hedberg; +Cc: linux-bluetooth, Loic Poulain
h5_reset_rx is unconditionally called at the end of
h5_complete_rx_pkt, no need to call it anymore after
that.
Signed-off-by: Loic Poulain <loic.poulain@intel.com>
---
v2: remove unused h5
drivers/bluetooth/hci_h5.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
index 04680ea..1fe9dba 100644
--- a/drivers/bluetooth/hci_h5.c
+++ b/drivers/bluetooth/hci_h5.c
@@ -355,10 +355,7 @@ static void h5_complete_rx_pkt(struct hci_uart *hu)
static int h5_rx_crc(struct hci_uart *hu, unsigned char c)
{
- struct h5 *h5 = hu->priv;
-
h5_complete_rx_pkt(hu);
- h5_reset_rx(h5);
return 0;
}
@@ -373,7 +370,6 @@ static int h5_rx_payload(struct hci_uart *hu, unsigned char c)
h5->rx_pending = 2;
} else {
h5_complete_rx_pkt(hu);
- h5_reset_rx(h5);
}
return 0;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx
2014-06-23 13:49 [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx Loic Poulain
@ 2014-06-23 14:04 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2014-06-23 14:04 UTC (permalink / raw)
To: Loic Poulain; +Cc: Gustavo F. Padovan, Johan Hedberg, linux-bluetooth
Hi Loic,
> h5_reset_rx is unconditionally called at the end of
> h5_complete_rx_pkt, no need to call it anymore after
> that.
>
> Signed-off-by: Loic Poulain <loic.poulain@intel.com>
> ---
> v2: remove unused h5
>
> drivers/bluetooth/hci_h5.c | 4 ----
> 1 file changed, 4 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-23 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 13:49 [PATCHv2] Bluetooth: Remove redundant calls to h5_reset_rx Loic Poulain
2014-06-23 14:04 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox