* [PATCH v2 0/2] Fix email submission address @ 2017-01-24 18:29 Brian Gix 2017-01-24 18:29 ` [PATCH v2 1/2] Add test-midi to ignore list Brian Gix 2017-01-24 18:29 ` [PATCH v2 2/2] Require GLIB v2.46 Brian Gix 0 siblings, 2 replies; 8+ messages in thread From: Brian Gix @ 2017-01-24 18:29 UTC (permalink / raw) To: linux-bluetooth The requirement for GLIB v2.46 was introduced in the test-midi unit test with the invocation of g_assert_cmpmem() ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] Add test-midi to ignore list 2017-01-24 18:29 [PATCH v2 0/2] Fix email submission address Brian Gix @ 2017-01-24 18:29 ` Brian Gix 2017-01-24 18:29 ` [PATCH v2 2/2] Require GLIB v2.46 Brian Gix 1 sibling, 0 replies; 8+ messages in thread From: Brian Gix @ 2017-01-24 18:29 UTC (permalink / raw) To: linux-bluetooth; +Cc: Brian Gix --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 6257505..c0745b4 100644 --- a/.gitignore +++ b/.gitignore @@ -138,6 +138,7 @@ unit/test-avdtp unit/test-avctp unit/test-avrcp unit/test-gatt +unit/test-midi unit/test-gattrib unit/test-*.log unit/test-*.trs -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 18:29 [PATCH v2 0/2] Fix email submission address Brian Gix 2017-01-24 18:29 ` [PATCH v2 1/2] Add test-midi to ignore list Brian Gix @ 2017-01-24 18:29 ` Brian Gix 2017-01-24 18:56 ` Felipe Ferreri Tonello 1 sibling, 1 reply; 8+ messages in thread From: Brian Gix @ 2017-01-24 18:29 UTC (permalink / raw) To: linux-bluetooth; +Cc: Brian Gix --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 91b4955..6d8bf9c 100644 --- a/configure.ac +++ b/configure.ac @@ -61,8 +61,8 @@ AC_CHECK_LIB(dl, dlopen, dummy=yes, AC_CHECK_HEADERS(linux/types.h linux/if_alg.h) -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, - AC_MSG_ERROR(GLib >= 2.28 is required)) +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.46, dummy=yes, + AC_MSG_ERROR(GLib >= 2.46 is required)) AC_SUBST(GLIB_CFLAGS) AC_SUBST(GLIB_LIBS) -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 18:29 ` [PATCH v2 2/2] Require GLIB v2.46 Brian Gix @ 2017-01-24 18:56 ` Felipe Ferreri Tonello 2017-01-24 19:04 ` Gix, Brian 0 siblings, 1 reply; 8+ messages in thread From: Felipe Ferreri Tonello @ 2017-01-24 18:56 UTC (permalink / raw) To: Brian Gix, linux-bluetooth [-- Attachment #1: Type: text/plain, Size: 712 bytes --] Hi Brian, Please, add the reason why this change is necessary in the commit message. On 24/01/17 18:29, Brian Gix wrote: > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 91b4955..6d8bf9c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -61,8 +61,8 @@ AC_CHECK_LIB(dl, dlopen, dummy=yes, > > AC_CHECK_HEADERS(linux/types.h linux/if_alg.h) > > -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, > - AC_MSG_ERROR(GLib >= 2.28 is required)) > +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.46, dummy=yes, > + AC_MSG_ERROR(GLib >= 2.46 is required)) > AC_SUBST(GLIB_CFLAGS) > AC_SUBST(GLIB_LIBS) > > -- Felipe [-- Attachment #2: 0x92698E6A.asc --] [-- Type: application/pgp-keys, Size: 7177 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 18:56 ` Felipe Ferreri Tonello @ 2017-01-24 19:04 ` Gix, Brian 2017-01-24 19:08 ` Szymon Janc 0 siblings, 1 reply; 8+ messages in thread From: Gix, Brian @ 2017-01-24 19:04 UTC (permalink / raw) To: Felipe Ferreri Tonello, linux-bluetooth@vger.kernel.org RG9uZS4NCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IGxpbnV4LWJsdWV0b290 aC1vd25lckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpsaW51eC1ibHVldG9vdGgtb3duZXJAdmdl ci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgRmVsaXBlIEZlcnJlcmkgVG9uZWxsbw0KU2VudDog VHVlc2RheSwgSmFudWFyeSAyNCwgMjAxNyAxMDo1NiBBTQ0KVG86IEdpeCwgQnJpYW4gPGJyaWFu LmdpeEBpbnRlbC5jb20+OyBsaW51eC1ibHVldG9vdGhAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0 OiBSZTogW1BBVENIIHYyIDIvMl0gUmVxdWlyZSBHTElCIHYyLjQ2DQoNCkhpIEJyaWFuLA0KDQpQ bGVhc2UsIGFkZCB0aGUgcmVhc29uIHdoeSB0aGlzIGNoYW5nZSBpcyBuZWNlc3NhcnkgaW4gdGhl IGNvbW1pdCBtZXNzYWdlLg0KDQpPbiAyNC8wMS8xNyAxODoyOSwgQnJpYW4gR2l4IHdyb3RlOg0K PiAtLS0NCj4gIGNvbmZpZ3VyZS5hYyB8IDQgKystLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9jb25maWd1cmUu YWMgYi9jb25maWd1cmUuYWMgaW5kZXggOTFiNDk1NS4uNmQ4YmY5YyAxMDA2NDQNCj4gLS0tIGEv Y29uZmlndXJlLmFjDQo+ICsrKyBiL2NvbmZpZ3VyZS5hYw0KPiBAQCAtNjEsOCArNjEsOCBAQCBB Q19DSEVDS19MSUIoZGwsIGRsb3BlbiwgZHVtbXk9eWVzLA0KPiAgDQo+ICBBQ19DSEVDS19IRUFE RVJTKGxpbnV4L3R5cGVzLmggbGludXgvaWZfYWxnLmgpDQo+ICANCj4gLVBLR19DSEVDS19NT0RV TEVTKEdMSUIsIGdsaWItMi4wID49IDIuMjgsIGR1bW15PXllcywNCj4gLQkJCQlBQ19NU0dfRVJS T1IoR0xpYiA+PSAyLjI4IGlzIHJlcXVpcmVkKSkNCj4gK1BLR19DSEVDS19NT0RVTEVTKEdMSUIs IGdsaWItMi4wID49IDIuNDYsIGR1bW15PXllcywNCj4gKwkJCQlBQ19NU0dfRVJST1IoR0xpYiA+ PSAyLjQ2IGlzIHJlcXVpcmVkKSkNCj4gIEFDX1NVQlNUKEdMSUJfQ0ZMQUdTKQ0KPiAgQUNfU1VC U1QoR0xJQl9MSUJTKQ0KPiAgDQo+IA0KDQotLQ0KRmVsaXBlDQo= ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 19:04 ` Gix, Brian @ 2017-01-24 19:08 ` Szymon Janc 2017-01-24 19:18 ` Gix, Brian 0 siblings, 1 reply; 8+ messages in thread From: Szymon Janc @ 2017-01-24 19:08 UTC (permalink / raw) To: Gix, Brian; +Cc: Felipe Ferreri Tonello, linux-bluetooth@vger.kernel.org Hi Brian, On 24 January 2017 at 20:04, Gix, Brian <brian.gix@intel.com> wrote: > Done. > > -----Original Message----- > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-owner@vger.kernel.org] On Behalf Of Felipe Ferreri Tonello > Sent: Tuesday, January 24, 2017 10:56 AM > To: Gix, Brian <brian.gix@intel.com>; linux-bluetooth@vger.kernel.org > Subject: Re: [PATCH v2 2/2] Require GLIB v2.46 > > Hi Brian, > > Please, add the reason why this change is necessary in the commit message. > > On 24/01/17 18:29, Brian Gix wrote: >> --- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac index 91b4955..6d8bf9c 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -61,8 +61,8 @@ AC_CHECK_LIB(dl, dlopen, dummy=yes, >> >> AC_CHECK_HEADERS(linux/types.h linux/if_alg.h) >> >> -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, >> - AC_MSG_ERROR(GLib >= 2.28 is required)) >> +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.46, dummy=yes, >> + AC_MSG_ERROR(GLib >= 2.46 is required)) >> AC_SUBST(GLIB_CFLAGS) >> AC_SUBST(GLIB_LIBS) I'd rather change test instead of bumping glib dependency just for this... But I'll let others to comment on this too. -- pozdrawiam Szymon K. Janc ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 19:08 ` Szymon Janc @ 2017-01-24 19:18 ` Gix, Brian 2017-01-24 19:25 ` Luiz Augusto von Dentz 0 siblings, 1 reply; 8+ messages in thread From: Gix, Brian @ 2017-01-24 19:18 UTC (permalink / raw) To: Szymon Janc; +Cc: Felipe Ferreri Tonello, linux-bluetooth@vger.kernel.org SGkgU3p5bW9uLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFN6eW1v biBKYW5jIFttYWlsdG86c3p5bW9uLmphbmNAY29kZWNvdXAucGxdDQo+IA0KPiBIaSBCcmlhbiwN Cj4gDQo+IE9uIDI0IEphbnVhcnkgMjAxNyBhdCAyMDowNCwgR2l4LCBCcmlhbiA8YnJpYW4uZ2l4 QGludGVsLmNvbT4gd3JvdGU6DQo+ID4gRG9uZS4NCj4gPg0KPiA+IC0tLS0tT3JpZ2luYWwgTWVz c2FnZS0tLS0tDQo+ID4gRnJvbTogbGludXgtYmx1ZXRvb3RoLW93bmVyQHZnZXIua2VybmVsLm9y ZyBbbWFpbHRvOmxpbnV4LWJsdWV0b290aC0NCj4gb3duZXJAdmdlci5rZXJuZWwub3JnXSBPbiBC ZWhhbGYgT2YgRmVsaXBlIEZlcnJlcmkgVG9uZWxsbw0KPiA+IFNlbnQ6IFR1ZXNkYXksIEphbnVh cnkgMjQsIDIwMTcgMTA6NTYgQU0NCj4gPiBUbzogR2l4LCBCcmlhbiA8YnJpYW4uZ2l4QGludGVs LmNvbT47IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtlcm5lbC5vcmcNCj4gPiBTdWJqZWN0OiBSZTog W1BBVENIIHYyIDIvMl0gUmVxdWlyZSBHTElCIHYyLjQ2DQo+ID4NCj4gPiBIaSBCcmlhbiwNCj4g Pg0KPiA+IFBsZWFzZSwgYWRkIHRoZSByZWFzb24gd2h5IHRoaXMgY2hhbmdlIGlzIG5lY2Vzc2Fy eSBpbiB0aGUgY29tbWl0DQo+IG1lc3NhZ2UuDQo+ID4NCj4gPiBPbiAyNC8wMS8xNyAxODoyOSwg QnJpYW4gR2l4IHdyb3RlOg0KPiA+PiAtLS0NCj4gPj4gIGNvbmZpZ3VyZS5hYyB8IDQgKystLQ0K PiA+PiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4g Pj4NCj4gPj4gZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYyBpbmRleCA5 MWI0OTU1Li42ZDhiZjljIDEwMDY0NA0KPiA+PiAtLS0gYS9jb25maWd1cmUuYWMNCj4gPj4gKysr IGIvY29uZmlndXJlLmFjDQo+ID4+IEBAIC02MSw4ICs2MSw4IEBAIEFDX0NIRUNLX0xJQihkbCwg ZGxvcGVuLCBkdW1teT15ZXMsDQo+ID4+DQo+ID4+ICBBQ19DSEVDS19IRUFERVJTKGxpbnV4L3R5 cGVzLmggbGludXgvaWZfYWxnLmgpDQo+ID4+DQo+ID4+IC1QS0dfQ0hFQ0tfTU9EVUxFUyhHTElC LCBnbGliLTIuMCA+PSAyLjI4LCBkdW1teT15ZXMsDQo+ID4+IC0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEFDX01TR19FUlJPUihHTGliID49IDIuMjggaXMgcmVxdWlyZWQpKQ0KPiA+PiAr UEtHX0NIRUNLX01PRFVMRVMoR0xJQiwgZ2xpYi0yLjAgPj0gMi40NiwgZHVtbXk9eWVzLA0KPiA+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBQ19NU0dfRVJST1IoR0xpYiA+PSAyLjQ2 IGlzIHJlcXVpcmVkKSkNCj4gPj4gIEFDX1NVQlNUKEdMSUJfQ0ZMQUdTKQ0KPiA+PiAgQUNfU1VC U1QoR0xJQl9MSUJTKQ0KPiANCj4gSSdkIHJhdGhlciBjaGFuZ2UgdGVzdCBpbnN0ZWFkIG9mIGJ1 bXBpbmcgZ2xpYiBkZXBlbmRlbmN5IGp1c3QgZm9yIHRoaXMuLi4NCj4gQnV0IEknbGwgbGV0IG90 aGVycyB0byBjb21tZW50IG9uIHRoaXMgdG9vLg0KDQoNCkkgYW0gZmluZSBlaXRoZXIgd2F5LiAg VGhlIGxhdGVzdCAoTFRTKSBVYnVudHUgYW5kIEZlZG9yYSBib3RoIGluY2x1ZGUgPj0gR0xJQiB2 Mi40NiBieSBkZWZhdWx0LCBzbyBJIGhhdmUgbm8gc3Ryb25nIHByZWZlcmVuY2UgYW55IHdheSwg aG93ZXZlciBpdCBpcyBvbmx5IHRoZSB1bml0IHRlc3QgdGhhdCB1c2VzIGl0LCBhbmQgbm8gQ29y ZSBCbHVlWiBjb2RlLg0KDQoNCg== ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] Require GLIB v2.46 2017-01-24 19:18 ` Gix, Brian @ 2017-01-24 19:25 ` Luiz Augusto von Dentz 0 siblings, 0 replies; 8+ messages in thread From: Luiz Augusto von Dentz @ 2017-01-24 19:25 UTC (permalink / raw) To: Gix, Brian Cc: Szymon Janc, Felipe Ferreri Tonello, linux-bluetooth@vger.kernel.org Hi Brian, Szymon, On Tue, Jan 24, 2017 at 9:18 PM, Gix, Brian <brian.gix@intel.com> wrote: > Hi Szymon, > >> -----Original Message----- >> From: Szymon Janc [mailto:szymon.janc@codecoup.pl] >> >> Hi Brian, >> >> On 24 January 2017 at 20:04, Gix, Brian <brian.gix@intel.com> wrote: >> > Done. >> > >> > -----Original Message----- >> > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth- >> owner@vger.kernel.org] On Behalf Of Felipe Ferreri Tonello >> > Sent: Tuesday, January 24, 2017 10:56 AM >> > To: Gix, Brian <brian.gix@intel.com>; linux-bluetooth@vger.kernel.org >> > Subject: Re: [PATCH v2 2/2] Require GLIB v2.46 >> > >> > Hi Brian, >> > >> > Please, add the reason why this change is necessary in the commit >> message. >> > >> > On 24/01/17 18:29, Brian Gix wrote: >> >> --- >> >> configure.ac | 4 ++-- >> >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> >> >> diff --git a/configure.ac b/configure.ac index 91b4955..6d8bf9c 100644 >> >> --- a/configure.ac >> >> +++ b/configure.ac >> >> @@ -61,8 +61,8 @@ AC_CHECK_LIB(dl, dlopen, dummy=yes, >> >> >> >> AC_CHECK_HEADERS(linux/types.h linux/if_alg.h) >> >> >> >> -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, >> >> - AC_MSG_ERROR(GLib >= 2.28 is required)) >> >> +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.46, dummy=yes, >> >> + AC_MSG_ERROR(GLib >= 2.46 is required)) >> >> AC_SUBST(GLIB_CFLAGS) >> >> AC_SUBST(GLIB_LIBS) >> >> I'd rather change test instead of bumping glib dependency just for this... >> But I'll let others to comment on this too. > > > I am fine either way. The latest (LTS) Ubuntu and Fedora both include >= GLIB v2.46 by default, so I have no strong preference any way, however it is only the unit test that uses it, and no Core BlueZ code. In the past we tried to not bump the glib requirements since there are some, probably many, embedded platforms using BlueZ that are stuck with ancient glib. That said we might actually start removing glib dependencies all together in favor of ell. -- Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-01-24 19:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-01-24 18:29 [PATCH v2 0/2] Fix email submission address Brian Gix 2017-01-24 18:29 ` [PATCH v2 1/2] Add test-midi to ignore list Brian Gix 2017-01-24 18:29 ` [PATCH v2 2/2] Require GLIB v2.46 Brian Gix 2017-01-24 18:56 ` Felipe Ferreri Tonello 2017-01-24 19:04 ` Gix, Brian 2017-01-24 19:08 ` Szymon Janc 2017-01-24 19:18 ` Gix, Brian 2017-01-24 19:25 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox