* [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+
@ 2017-04-28 11:26 Frédéric Danis
2017-04-28 11:44 ` Sebastian Reichel
2017-04-28 16:06 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Frédéric Danis @ 2017-04-28 11:26 UTC (permalink / raw)
To: sre; +Cc: linux-bluetooth, frederic.danis.oss
Fix the following error preventing to load Nokia H4+ module:
kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
kernel: [ 826.461629] Disabling lock debugging due to kernel taint
kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)
Signed-off-by: Frédéric Danis <frederic.danis.oss@gmail.com>
---
drivers/bluetooth/hci_nokia.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
index 4038daf..c563f3c 100644
--- a/drivers/bluetooth/hci_nokia.c
+++ b/drivers/bluetooth/hci_nokia.c
@@ -36,6 +36,8 @@
#include "hci_uart.h"
#include "btbcm.h"
+#define VERSION "0.1"
+
#define NOKIA_ID_BCM2048 0x04
#define NOKIA_ID_TI1271 0x31
@@ -818,3 +820,8 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
};
module_serdev_device_driver(nokia_bluetooth_serdev_driver);
+
+MODULE_AUTHOR("Sebastian Reichel <sre@kernel.org>-");
+MODULE_DESCRIPTION("Bluetooth HCI UART Nokia H4+ driver ver " VERSION);
+MODULE_VERSION(VERSION);
+MODULE_LICENSE("GPL");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+
2017-04-28 11:26 [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+ Frédéric Danis
@ 2017-04-28 11:44 ` Sebastian Reichel
2017-04-28 16:06 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2017-04-28 11:44 UTC (permalink / raw)
To: Frédéric Danis; +Cc: linux-bluetooth
[-- Attachment #1: Type: text/plain, Size: 3757 bytes --]
Hi,
On Fri, Apr 28, 2017 at 01:26:11PM +0200, Frédéric Danis wrote:
> Fix the following error preventing to load Nokia H4+ module:
> kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
> kernel: [ 826.461629] Disabling lock debugging due to kernel taint
> kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
> kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
> kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
> kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
> kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
> kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
> kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
> kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
> kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
> kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
> kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
> kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
> kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
> kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
> kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
> kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
> kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
> kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
> kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
> kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
> kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
> kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
> kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
> kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
> kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
> kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
> kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
> kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
> kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
> kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)
>
> Signed-off-by: Frédéric Danis <frederic.danis.oss@gmail.com>
> ---
> drivers/bluetooth/hci_nokia.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
> index 4038daf..c563f3c 100644
> --- a/drivers/bluetooth/hci_nokia.c
> +++ b/drivers/bluetooth/hci_nokia.c
> @@ -36,6 +36,8 @@
> #include "hci_uart.h"
> #include "btbcm.h"
>
> +#define VERSION "0.1"
> +
> #define NOKIA_ID_BCM2048 0x04
> #define NOKIA_ID_TI1271 0x31
>
> @@ -818,3 +820,8 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
> };
>
> module_serdev_device_driver(nokia_bluetooth_serdev_driver);
> +
> +MODULE_AUTHOR("Sebastian Reichel <sre@kernel.org>-");
There is a superfluous - at end of string.
> +MODULE_DESCRIPTION("Bluetooth HCI UART Nokia H4+ driver ver " VERSION);
> +MODULE_VERSION(VERSION);
> +MODULE_LICENSE("GPL");
Otherwise:
Acked-by: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+
2017-04-28 11:26 [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+ Frédéric Danis
2017-04-28 11:44 ` Sebastian Reichel
@ 2017-04-28 16:06 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2017-04-28 16:06 UTC (permalink / raw)
To: Frédéric Danis; +Cc: Sebastian Reichel, linux-bluetooth
Hi Fred,
> Fix the following error preventing to load Nokia H4+ module:
> kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
> kernel: [ 826.461629] Disabling lock debugging due to kernel taint
> kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
> kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
> kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
> kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
> kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
> kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
> kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
> kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
> kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
> kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
> kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
> kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
> kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
> kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
> kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
> kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
> kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
> kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
> kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
> kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
> kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
> kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
> kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
> kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
> kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
> kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
> kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
> kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
> kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
> kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)
>
> Signed-off-by: Frédéric Danis <frederic.danis.oss@gmail.com>
> ---
> drivers/bluetooth/hci_nokia.c | 7 +++++++
> 1 file changed, 7 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-28 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 11:26 [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+ Frédéric Danis
2017-04-28 11:44 ` Sebastian Reichel
2017-04-28 16:06 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox