From: Bastien Nocera <hadess@hadess.net>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] gdbus: Force service to start if proxy is created while not connected
Date: Tue, 28 Nov 2017 14:47:47 +0100 [thread overview]
Message-ID: <1511876867.11411.41.camel@hadess.net> (raw)
In-Reply-To: <20171128105746.13000-1-luiz.dentz@gmail.com>
On Tue, 2017-11-28 at 12:57 +0200, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> Because GetAll is no longer send right away the service may never be
> started.
Causes an assertion on startup on my machine.
dbus[12994]: arguments to dbus_message_unref() were incorrect, assertion "!message->in_cache" failed in file ../../dbus/dbus-message.c line 1718.
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1 0x00007ffff6b752a7 in __GI_abort () at abort.c:90
#2 0x00007ffff76618c4 in _dbus_abort () from /lib64/libdbus-1.so.3
#3 0x00007ffff7658150 in _dbus_warn_check_failed () from /lib64/libdbus-1.so.3
#4 0x000000000048b281 in start_service (proxy=0x70a4f0) at gdbus/client.c:505
#5 g_dbus_proxy_new (client=<optimized out>, path=path@entry=0x49bcad "/org/freedesktop/hostname1", interface=interface@entry=0x49bcc8 "org.freedesktop.hostname1") at gdbus/client.c:527
#6 0x000000000040cb9d in hostname_init () at plugins/hostname.c:287
#7 0x000000000045617a in plugin_init (enable=<optimized out>, disable=<optimized out>) at src/plugin.c:200
#8 0x000000000040bc9e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:744
Looks like g_dbus_send_message() takes ownership of the reference to
the message. Removing that call in your patch makes it work.
Might want to double-check though.
next prev parent reply other threads:[~2017-11-28 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 10:57 [PATCH BlueZ] gdbus: Force service to start if proxy is created while not connected Luiz Augusto von Dentz
2017-11-28 13:47 ` Bastien Nocera [this message]
2017-11-28 13:49 ` Luiz Augusto von Dentz
2017-11-28 13:58 ` Bastien Nocera
2017-11-28 14:23 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511876867.11411.41.camel@hadess.net \
--to=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox