Linux bluetooth development
 help / color / mirror / Atom feed
* [PATCH BlueZ] gdbus: Force service to start if proxy is created while not connected
@ 2017-11-28 10:57 Luiz Augusto von Dentz
  2017-11-28 13:47 ` Bastien Nocera
  0 siblings, 1 reply; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2017-11-28 10:57 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Because GetAll is no longer send right away the service may never be
started.
---
 gdbus/client.c | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gdbus/client.c b/gdbus/client.c
index 9b0f7f7a9..3d7105ef8 100644
--- a/gdbus/client.c
+++ b/gdbus/client.c
@@ -484,6 +484,28 @@ static void proxy_remove(GDBusClient *client, const char *path,
 	}
 }
 
+static void start_service(GDBusProxy *proxy)
+{
+	GDBusClient *client = proxy->client;
+	const char *service_name = client->service_name;
+	dbus_uint32_t flags = 0;
+	DBusMessage *msg;
+
+	msg = dbus_message_new_method_call(DBUS_SERVICE_DBUS, DBUS_PATH_DBUS,
+						DBUS_INTERFACE_DBUS,
+						"StartServiceByName");
+	if (msg == NULL)
+		return;
+
+	dbus_message_append_args(msg, DBUS_TYPE_STRING, &service_name,
+					DBUS_TYPE_UINT32, &flags,
+					DBUS_TYPE_INVALID);
+
+	g_dbus_send_message(client->dbus_conn, msg);
+	dbus_message_unref(msg);
+	return;
+}
+
 GDBusProxy *g_dbus_proxy_new(GDBusClient *client, const char *path,
 							const char *interface)
 {
@@ -500,7 +522,13 @@ GDBusProxy *g_dbus_proxy_new(GDBusClient *client, const char *path,
 	if (proxy == NULL)
 		return NULL;
 
-	if (client->connected && !client->get_objects_call)
+	if (!client->connected) {
+		/* Force service to start */
+		start_service(proxy);
+		return g_dbus_proxy_ref(proxy);
+	}
+
+	if (!client->get_objects_call)
 		get_all_properties(proxy);
 
 	return g_dbus_proxy_ref(proxy);
-- 
2.13.6


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-28 14:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 10:57 [PATCH BlueZ] gdbus: Force service to start if proxy is created while not connected Luiz Augusto von Dentz
2017-11-28 13:47 ` Bastien Nocera
2017-11-28 13:49   ` Luiz Augusto von Dentz
2017-11-28 13:58     ` Bastien Nocera
2017-11-28 14:23       ` Luiz Augusto von Dentz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox