public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] mesh: Fix invalid netkey index in appkey add/delete
       [not found] <CGME20191203095335epcas5p2f42315a8d7d9a081afa929f96bb66356@epcas5p2.samsung.com>
@ 2019-12-03  9:53 ` Nagaraj D R
  2019-12-03 18:49   ` Gix, Brian
  0 siblings, 1 reply; 2+ messages in thread
From: Nagaraj D R @ 2019-12-03  9:53 UTC (permalink / raw)
  To: linux-bluetooth

8 LSbs of netkey index should be packed into the first octet
---
 tools/mesh-gatt/config-client.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/mesh-gatt/config-client.c b/tools/mesh-gatt/config-client.c
index 5e6374f..ed31c67 100644
--- a/tools/mesh-gatt/config-client.c
+++ b/tools/mesh-gatt/config-client.c
@@ -591,7 +591,7 @@ static void cmd_app_key(int argc, char *argv[], uint32_t opcode)
 		return bt_shell_noninteractive_quit(EXIT_FAILURE);
 	}
 
-	msg[n++] = net_idx & 0xf;
+	msg[n++] = net_idx & 0xff;
 	msg[n++] = ((net_idx >> 8) & 0xf) |
 		((app_idx << 4) & 0xf0);
 	msg[n++] = app_idx >> 4;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] mesh: Fix invalid netkey index in appkey add/delete
  2019-12-03  9:53 ` [PATCH 1/1] mesh: Fix invalid netkey index in appkey add/delete Nagaraj D R
@ 2019-12-03 18:49   ` Gix, Brian
  0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2019-12-03 18:49 UTC (permalink / raw)
  To: linux-bluetooth@vger.kernel.org, nagaraj.dr@samsung.com

Applied

On Tue, 2019-12-03 at 15:23 +0530, Nagaraj D R wrote:
> 8 LSbs of netkey index should be packed into the first octet
> ---
>  tools/mesh-gatt/config-client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/mesh-gatt/config-client.c b/tools/mesh-gatt/config-client.c
> index 5e6374f..ed31c67 100644
> --- a/tools/mesh-gatt/config-client.c
> +++ b/tools/mesh-gatt/config-client.c
> @@ -591,7 +591,7 @@ static void cmd_app_key(int argc, char *argv[], uint32_t opcode)
>  		return bt_shell_noninteractive_quit(EXIT_FAILURE);
>  	}
>  
> -	msg[n++] = net_idx & 0xf;
> +	msg[n++] = net_idx & 0xff;
>  	msg[n++] = ((net_idx >> 8) & 0xf) |
>  		((app_idx << 4) & 0xf0);
>  	msg[n++] = app_idx >> 4;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-03 18:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20191203095335epcas5p2f42315a8d7d9a081afa929f96bb66356@epcas5p2.samsung.com>
2019-12-03  9:53 ` [PATCH 1/1] mesh: Fix invalid netkey index in appkey add/delete Nagaraj D R
2019-12-03 18:49   ` Gix, Brian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox