* [PATCH] andorid/handsfree.c setting sizeof struct properly for sco_handlers[]
@ 2015-04-02 3:45 Prabhu Chawandi
2015-04-03 10:59 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Prabhu Chawandi @ 2015-04-02 3:45 UTC (permalink / raw)
To: Szymon Janc, linux-bluetooth
diff --git a/android/handsfree.c b/android/handsfree.c
index 7cdc8b4..e6c4b1b 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -2891,7 +2891,7 @@ failed:
static const struct ipc_handler sco_handlers[] = {
/* SCO_OP_GET_FD */
- { bt_sco_get_fd, false, 0 }
+ { bt_sco_get_fd, false, sizeof(struct sco_cmd_get_fd) }
};
static void bt_sco_unregister(void)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] andorid/handsfree.c setting sizeof struct properly for sco_handlers[]
2015-04-02 3:45 [PATCH] andorid/handsfree.c setting sizeof struct properly for sco_handlers[] Prabhu Chawandi
@ 2015-04-03 10:59 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2015-04-03 10:59 UTC (permalink / raw)
To: Prabhu Chawandi; +Cc: linux-bluetooth
Hi Prabhu,
On Thursday 02 of April 2015 09:15:14 Prabhu Chawandi wrote:
There is typo in commit subject andorid->android
Also please use 'fix' term in commit subject eg
"android/handsfree: Fix invalid size of SCO_OP_GET_FD parameters"
And this patch doesn't apply on top of master branch so you will have to
rebase it before resend.
> diff --git a/android/handsfree.c b/android/handsfree.c
> index 7cdc8b4..e6c4b1b 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -2891,7 +2891,7 @@ failed:
>
> static const struct ipc_handler sco_handlers[] = {
> /* SCO_OP_GET_FD */
> - { bt_sco_get_fd, false, 0 }
> + { bt_sco_get_fd, false, sizeof(struct sco_cmd_get_fd) }
> };
>
> static void bt_sco_unregister(void)
--
BR
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-03 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-02 3:45 [PATCH] andorid/handsfree.c setting sizeof struct properly for sco_handlers[] Prabhu Chawandi
2015-04-03 10:59 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox