[BlueZ PATCH v2] configure: Check ell path

[BlueZ PATCH v2] configure: Check ell path

[Tedd Ho-Jeong An]

From: Tedd Ho-Jeong An <tedd.an@intel.com>

If the 'enable-external-ell' is not specified in the configure parameter,
the build system assumes that the ELL source is located same level where
the bluez source is cloned. But the configure doens't check the folder
and user will get the build error while building the source.

This patch checks if the ELL source path if the 'enable-external-ell'
flag is not set and throws an error if the ELL doesn't exist.
---
 configure.ac | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configure.ac b/configure.ac
index f9f0faf57..515cdf146 100644
--- a/configure.ac
+++ b/configure.ac
@@ -289,6 +289,11 @@ if (test "${enable_external_ell}" = "yes"); then
 	AC_SUBST(ELL_CFLAGS)
 	AC_SUBST(ELL_LIBS)
 fi
+if (test "${enable_external_ell}" != "yes"); then
+	AC_CHECK_FILE(${srcdir}/ell/ell.h, dummy=yes,
+			AC_CHECK_FILE(${srcdir}/../ell/ell/ell.h, dummy=yes,
+				AC_MSG_ERROR(ELL source is required or use --enable-external-ell)))
+fi
 AM_CONDITIONAL(EXTERNAL_ELL, test "${enable_external_ell}" = "yes" ||
 				(test "${enable_btpclient}" != "yes" &&
 						test "${enable_mesh}" != "yes"))
-- 
2.39.2

RE: [BlueZ,v2] configure: Check ell path

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=723518

---Test result---

Test Summary:
CheckPatch                    PASS      0.30 seconds
GitLint                       PASS      0.24 seconds
BuildEll                      PASS      26.81 seconds
BluezMake                     PASS      751.72 seconds
MakeCheck                     PASS      11.17 seconds
MakeDistcheck                 PASS      147.79 seconds
CheckValgrind                 PASS      240.71 seconds
CheckSmatch                   PASS      319.26 seconds
bluezmakeextell               PASS      95.72 seconds
IncrementalBuild              PASS      607.91 seconds
ScanBuild                     PASS      941.47 seconds



---
Regards,
Linux Bluetooth

Re: [BlueZ PATCH v2] configure: Check ell path

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 20 Feb 2023 10:12:05 -0800 you wrote:
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
> 
> If the 'enable-external-ell' is not specified in the configure parameter,
> the build system assumes that the ELL source is located same level where
> the bluez source is cloned. But the configure doens't check the folder
> and user will get the build error while building the source.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2] configure: Check ell path
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1106b28be85a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html