From: Szymon Janc <szymon.janc@tieto.com>
To: Sujay Sarkhel <ssarkhe@ncsu.edu>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: Thermometer D-Bus API Signature
Date: Wed, 19 Nov 2014 19:55:32 +0100 [thread overview]
Message-ID: <1721045.kgzKbrT3eS@leonov> (raw)
In-Reply-To: <CAE7yNv9vBFaBincdFbf=jRGMd1iD-biA4FRhwi5k4b2i2Wdt6Q@mail.gmail.com>
Hi Sujay,
On Friday 14 of November 2014 20:13:13 Sujay Sarkhel wrote:
> I was looking at the Health Thermometer Watcher hierarchy under
> docs/thermometer-api.txt and I guess the signature for the following
> method is incorrect:
>
> void MeasurementReceived(dict measurement)
>
> In my opinion, it should be:
>
> void MeasurementReceived(object device, dict measurement)
>
> i.e. same as the one defined under heartrate-api.txt
>
> Unfortunately, I do not have an actual thermometer or an emulator to
> verify this but looking at the source code:
> https://git.kernel.org/cgit/bluetooth/bluez.git/tree/profiles/thermometer/th
> ermometer.c for the method update_watcher (line #277), it looks that way.
>
> Can some developer kindly verify this please? Thanks!
Yes, this looks like documentation issue. Care to send a patch?:)
--
BR
Szymon Janc
prev parent reply other threads:[~2014-11-19 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 4:13 Thermometer D-Bus API Signature Sujay Sarkhel
2014-11-19 18:55 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1721045.kgzKbrT3eS@leonov \
--to=szymon.janc@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ssarkhe@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox