Thermometer D-Bus API Signature

Thermometer D-Bus API Signature

[Sujay Sarkhel]

I was looking at the Health Thermometer Watcher hierarchy under
docs/thermometer-api.txt and I guess the signature for the following
method is incorrect:

           void MeasurementReceived(dict measurement)

In my opinion, it should be:

       void MeasurementReceived(object device, dict measurement)

i.e. same as the one defined under heartrate-api.txt

Unfortunately, I do not have an actual thermometer or an emulator to
verify this but looking at the source code:
https://git.kernel.org/cgit/bluetooth/bluez.git/tree/profiles/thermometer/thermometer.c
for the method update_watcher (line #277), it looks that way.

Can some developer kindly verify this please? Thanks!

Regards,
Sujay Sarkhel

Re: Thermometer D-Bus API Signature

[Szymon Janc]

Hi Sujay,

On Friday 14 of November 2014 20:13:13 Sujay Sarkhel wrote:
> I was looking at the Health Thermometer Watcher hierarchy under
> docs/thermometer-api.txt and I guess the signature for the following
> method is incorrect:
> 
>            void MeasurementReceived(dict measurement)
> 
> In my opinion, it should be:
> 
>        void MeasurementReceived(object device, dict measurement)
> 
> i.e. same as the one defined under heartrate-api.txt
> 
> Unfortunately, I do not have an actual thermometer or an emulator to
> verify this but looking at the source code:
> https://git.kernel.org/cgit/bluetooth/bluez.git/tree/profiles/thermometer/th
> ermometer.c for the method update_watcher (line #277), it looks that way.
> 
> Can some developer kindly verify this please? Thanks!

Yes, this looks like documentation issue. Care to send a patch?:)

-- 
BR
Szymon Janc