[Patch] support libical 4.0

[Patch] support libical 4.0

[Funda Wang]

[-- Attachment #1.1: Type: text/plain, Size: 264 bytes --]

Hello,

Since libical 4.0 [1], pkgconfig files of libical have been splitted into several files according to libraries. The libical pkgconfig check need to be tweaked to check libicalvcal. Patch attached.

Thanks.

[1]: https://github.com/libical/libical/pull/988

[-- Attachment #1.2: Type: text/html, Size: 285 bytes --]

[-- Attachment #2: bluez-5.86-support-ical-4.0.patch.txt --]
[-- Type: text/plain, Size: 778 bytes --]

From e5128e1124efa814d8c65b4797025b1a15c6b250 Mon Sep 17 00:00:00 2001
From: Funda Wang <fundawang@yeah.net>
Date: Mon, 11 May 2026 12:37:35 +0800
Subject: [PATCH] support libical 4.0

---
 configure.ac | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 52de7d6..1cdd551 100644
--- a/configure.ac
+++ b/configure.ac
@@ -306,7 +306,9 @@ fi
 AC_ARG_ENABLE(obex, AS_HELP_STRING([--disable-obex],
 		[disable OBEX profile support]), [enable_obex=${enableval}])
 if (test "${enable_obex}" != "no"); then
-	PKG_CHECK_MODULES(ICAL, libical)
+	PKG_CHECK_MODULES(ICAL, [libicalvcal >= 4.0.0], [],
+                [PKG_CHECK_MODULES(ICAL, [libical])]
+        )
 fi
 AM_CONDITIONAL(OBEX, test "${enable_obex}" != "no")
 
-- 
2.47.3

Re: [Patch] support libical 4.0

[Bastien Nocera]

On Mon, 2026-05-11 at 13:58 +0800, Funda Wang wrote:
> Hello,
> 
> Since libical 4.0 [1], pkgconfig files of libical have been splitted
> into several files according to libraries. The libical pkgconfig
> check need to be tweaked to check libicalvcal. Patch attached.

That breaks libical < 4.0, which is still the current version on most
stable distributions.

And please follow the instructions at:
https://github.com/bluez/bluez/blob/master/HACKING#L98
for how to send patches.

Regards

> 
> Thanks.
> 
> [1]: https://github.com/libical/libical/pull/988

Re: [Patch] support libical 4.0

[Bastien Nocera]

On Mon, 2026-05-11 at 09:44 +0200, Bastien Nocera wrote:
> On Mon, 2026-05-11 at 13:58 +0800, Funda Wang wrote:
> > Hello,
> > 
> > Since libical 4.0 [1], pkgconfig files of libical have been
> > splitted
> > into several files according to libraries. The libical pkgconfig
> > check need to be tweaked to check libicalvcal. Patch attached.
> 
> That breaks libical < 4.0, which is still the current version on most
> stable distributions.

I read the patch incorrectly, and it doe work with older versions of
libical.

> 
> And please follow the instructions at:
> https://github.com/bluez/bluez/blob/master/HACKING#L98
> for how to send patches.

I've re-sent the patch in the proper format so it can be included in
the upcoming release.

> 
> Regards
> 
> > 
> > Thanks.
> > 
> > [1]: https://github.com/libical/libical/pull/988

RE: support libical 4.0

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----


Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth

Re: [Patch] support libical 4.0

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 11 May 2026 13:58:38 +0800 (CST) you wrote:
> Hello,
> 
> Since libical 4.0 [1], pkgconfig files of libical have been splitted into several files according to libraries. The libical pkgconfig check need to be tweaked to check libicalvcal. Patch attached.
> 
> Thanks.
> 
> [1]: https://github.com/libical/libical/pull/988
> From e5128e1124efa814d8c65b4797025b1a15c6b250 Mon Sep 17 00:00:00 2001
> From: Funda Wang <fundawang@yeah.net>
> Date: Mon, 11 May 2026 12:37:35 +0800
> Subject: [PATCH] support libical 4.0
> 
> [...]

Here is the summary with links:
  - support libical 4.0
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e60d07255327

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html