From: patchwork-bot+bluetooth@kernel.org
To: Gongwei Li <13875017792@163.com>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com,
loic.poulain@oss.qualcomm.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, ligongwei@kylinos.cn
Subject: Re: [PATCH v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout()
Date: Mon, 31 Aug 2026 17:20:10 +0000 [thread overview]
Message-ID: <178819681074.671757.16650865347821442609.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260825020145.2840983-1-13875017792@163.com>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Tue, 25 Aug 2026 10:01:45 +0800 you wrote:
> From: Gongwei Li <ligongwei@kylinos.cn>
>
> wait_on_bit_timeout() returns 0 if the bit was cleared, -EINTR if the
> process received a signal and the mode permitted wake up on that signal,
> or -EAGAIN if the timeout elapsed. It never returns 1.
>
> Hence the check "err == 1" in mrvl_load_firmware() is dead code: when
> the waiting task is interrupted by a signal (-EINTR), the code falls
> into the "else if (err)" branch and misreports it as "Firmware request
> timeout" with -ETIMEDOUT instead of propagating -EINTR.
>
> [...]
Here is the summary with links:
- [v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout()
https://git.kernel.org/bluetooth/bluetooth-next/c/870187be2362
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-08-31 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 2:01 [PATCH v2] Bluetooth: hci_mrvl: Fix wrong return value check of wait_on_bit_timeout() Gongwei Li
2026-08-31 17:20 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178819681074.671757.16650865347821442609.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=13875017792@163.com \
--cc=ligongwei@kylinos.cn \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox